Bug 8971 - Sort holds queue report using DataTables
Summary: Sort holds queue report using DataTables
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Paul Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 16:38 UTC by Owen Leonard
Modified: 2013-12-05 20:06 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8971 - Sort holds queue report using DataTables (2.05 KB, patch)
2012-10-25 16:53 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8971 - Sort holds queue report using DataTables (2.10 KB, patch)
2012-11-02 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 8971 - Sort holds queue report using DataTables (2.12 KB, patch)
2012-11-20 11:20 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-10-25 16:38:31 UTC
There are bugs with the sort on the holds queue report stemming from the fact that the tablesorter plugin doesn't handle whitespace and markup in table cells very well. The DataTables plugin doesn't seem to mind, so this is a worthwhile replacement.
Comment 1 Owen Leonard 2012-10-25 16:53:58 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-11-02 14:37:04 UTC Comment hidden (obsolete)
Comment 3 Mason James 2012-11-09 02:16:36 UTC
(In reply to comment #1)
> Created attachment 13056 [details] [review]
> Bug 8971 - Sort holds queue report using DataTables
> 
> Replacing the old tablesorter plugin with DataTables on
> this page will fix sorting bugs related to whitespace and
> markup in table cells which tablesorter couldn't handle.
> 
> I have also taken the liberty of changing the default sort
> from patron to call number, assuming that the librarian
> uses this list to pull items from the shelf, and the shelf
> is organized by call number.

hmm, can i get a url and/or screenshot for this bug?

i dont know where/what to test, currently...
Comment 4 Owen Leonard 2012-11-09 14:02:48 UTC
"Holds queue" from the circulation home page: /cgi-bin/koha/circ/view_holdsqueue.pl

To test, confirm that table sorting works correctly on all columns of the report, and consider whether sorting by call number by default is a helpful rather than harmful change.
Comment 5 Paul Poulain 2012-11-20 11:19:57 UTC
QA comment:
 * small patch, template only, no string change
 * passes koha-qa.pl
 * do the announced job

passed QA
Comment 6 Paul Poulain 2012-11-20 11:20:14 UTC
Created attachment 13549 [details] [review]
Bug 8971 - Sort holds queue report using DataTables

Replacing the old tablesorter plugin with DataTables on
this page will fix sorting bugs related to whitespace and
markup in table cells which tablesorter couldn't handle.

I have also taken the liberty of changing the default sort
from patron to call number, assuming that the librarian
uses this list to pull items from the shelf, and the shelf
is organized by call number.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 7 Jared Camins-Esakov 2012-11-20 13:19:12 UTC
This patch has been pushed to master.
Comment 8 Paul Poulain 2012-11-20 15:59:18 UTC
Patch pushed to branch 3.10.x
Comment 9 Chris Cormack 2013-04-23 10:16:41 UTC
Released in 3.10.0