There are bugs with the sort on the holds queue report stemming from the fact that the tablesorter plugin doesn't handle whitespace and markup in table cells very well. The DataTables plugin doesn't seem to mind, so this is a worthwhile replacement.
Created attachment 13056 [details] [review] Bug 8971 - Sort holds queue report using DataTables Replacing the old tablesorter plugin with DataTables on this page will fix sorting bugs related to whitespace and markup in table cells which tablesorter couldn't handle. I have also taken the liberty of changing the default sort from patron to call number, assuming that the librarian uses this list to pull items from the shelf, and the shelf is organized by call number.
Created attachment 13232 [details] [review] [SIGNED-OFF] Bug 8971 - Sort holds queue report using DataTables Replacing the old tablesorter plugin with DataTables on this page will fix sorting bugs related to whitespace and markup in table cells which tablesorter couldn't handle. I have also taken the liberty of changing the default sort from patron to call number, assuming that the librarian uses this list to pull items from the shelf, and the shelf is organized by call number. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to comment #1) > Created attachment 13056 [details] [review] > Bug 8971 - Sort holds queue report using DataTables > > Replacing the old tablesorter plugin with DataTables on > this page will fix sorting bugs related to whitespace and > markup in table cells which tablesorter couldn't handle. > > I have also taken the liberty of changing the default sort > from patron to call number, assuming that the librarian > uses this list to pull items from the shelf, and the shelf > is organized by call number. hmm, can i get a url and/or screenshot for this bug? i dont know where/what to test, currently...
"Holds queue" from the circulation home page: /cgi-bin/koha/circ/view_holdsqueue.pl To test, confirm that table sorting works correctly on all columns of the report, and consider whether sorting by call number by default is a helpful rather than harmful change.
QA comment: * small patch, template only, no string change * passes koha-qa.pl * do the announced job passed QA
Created attachment 13549 [details] [review] Bug 8971 - Sort holds queue report using DataTables Replacing the old tablesorter plugin with DataTables on this page will fix sorting bugs related to whitespace and markup in table cells which tablesorter couldn't handle. I have also taken the liberty of changing the default sort from patron to call number, assuming that the librarian uses this list to pull items from the shelf, and the shelf is organized by call number. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch has been pushed to master.
Patch pushed to branch 3.10.x
Released in 3.10.0