The file check misc/cronjobs/rss/rss.pl uses HTML::Template::Pro. It should be converted to use Template::Toolkit, or, if it is a legacy script, removed.
I remember trying to work with this RSS feed generator years ago but I don't think it's used anymore. As far as I know misc/cronjobs/rss can be removed altogether.
(In reply to comment #1) > I don't think it's used anymore. No, it is used by several libraries we work for.
Then it desperately needs to be fixed, because we don't want to keep it using HTML::Template::Pro
(In reply to Fridolin SOMERS from comment #2) > (In reply to comment #1) > > I don't think it's used anymore. > No, it is used by several libraries we work for. Sorry, I've checked and none of our libraries use this, I've mixed up with something else. It can be removed.
Since misc/cronjobs/rss/rss.pl is not used anymore, it should be removed. Moreover, this file contains old dependencies with the module HTML::Template::Pro. For a new user of Koha, which launchs the test of t/db_dependent/00-strict.t , it prints : t/db_dependent/00-strict.t ............................. 363/? # Failed test 'Syntax check misc/cronjobs/rss/rss.pl' # at /usr/share/perl5/Test/Strict.pm line 394. # Can't locate HTML/Template/Pro.pm in @INC (you may need to install the HTML::Template::Pro module) (@INC contains: installer misc/translator /home/yohann/koha /home/yohann/qa-test-tools /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl . /home/yohann/koha /home/yohann/qa-test-tools /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at misc/cronjobs/rss/rss.pl line 30. # BEGIN failed--compilation aborted at misc/cronjobs/rss/rss.pl line 30.
Created attachment 29088 [details] [review] Bug 9000: the directory misc/cronjobs/rss/ has been removed Since these files are not used anymore, they can be removed.
Created attachment 29127 [details] [review] [SIGNED-OFF] Bug 9000: the directory misc/cronjobs/rss/ has been removed Since these files are not used anymore, they can be removed. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Files removed, no errors.
*** Bug 10700 has been marked as a duplicate of this bug. ***
I am not entirely sure about removing these, as the feature seems still functional. I managed to create an XML file with the last Acquired records by installing HTP and running ./rss.pl lastAcquired.conf. Of course there are a couple of problems: The generated XML file is currently only available in English, the feature depends on HTP. As the feature is separate to Koha and can easily be restored, I will pass QA.
Created attachment 29134 [details] [review] [PASSED QA] Bug 9000: the directory misc/cronjobs/rss/ has been removed Since these files are not used anymore, they can be removed. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Files removed, no errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch removes RSS related files that still depend on HTP.
A counter patch migut easily change the syntax and avoid loosing the feature that seems to be used by some libraries.
Created attachment 30202 [details] [review] Bug 9000 [1] - Update rss.pl to use Template Toolkit
Created attachment 30203 [details] [review] Bug 9000 [2] - Update included examples
Created attachment 30204 [details] [review] Bug 9000 [3] - Change conf key from tmpl to template
Created attachment 30205 [details] [review] Bug 9000 [4] - Update to GPL v3
Created attachment 30206 [details] [review] Bug 9000 [3] - Change conf key from tmpl to template
Created attachment 30207 [details] [review] Bug 9000 [4] - Update to GPL v3
Cheers for this Kyle, I've raised it with our guys to test and go forth and sign-off. Martin
Created attachment 30219 [details] [review] [SIGNED-OFF] Bug 9000 [1] - Update rss.pl to use Template Toolkit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested using script with sample conf files RSS feeds generated are 'well formed' xml Some koha-qa errors fixed in followup
Created attachment 30220 [details] [review] [SIGNED-OFF] Bug 9000 [2] - Update included examples Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 30221 [details] [review] [SIGNED-OFF] Bug 9000 [3] - Change conf key from tmpl to template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 30222 [details] [review] [SIGNED-OFF] Bug 9000 [4] - Update to GPL v3 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 30223 [details] [review] Bug 9000: Followup to fix tabs & closing TT directive
Created attachment 30229 [details] [review] [PASSED QA] Bug 9000 [1] - Update rss.pl to use Template Toolkit Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested using script with sample conf files RSS feeds generated are 'well formed' xml Some koha-qa errors fixed in followup Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 30230 [details] [review] [PASSED QA] Bug 9000 [2] - Update included examples Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 30231 [details] [review] [PASSED QA] Bug 9000 [3] - Change conf key from tmpl to template Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 30232 [details] [review] [PASSED QA] Bug 9000 [4] - Update to GPL v3 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 30233 [details] [review] [PASSED QA] Bug 9000: Followup to fix tabs & closing TT directive Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Happy to pass QA on this.. thanks so much for getting to this Kyle, and beating my team to sign-off Bernardo meaning I could QA. I took the initiative of taking Bernardo's patch straight to QA as it was simply a white-space fix to make git not complain ;) Go forth and push fair RM ;)
Patches pushed to master. Thanks Kyle!!
Hi all, Can someone help me out here and tell me if/how this changes this section of the manual? http://manual.koha-community.org/3.16/en/opacenhancedcontent.html#customrss Thanks! Nicole