Bug 9000 - misc/cronjobs/rss/rss.pl uses HTP
Summary: misc/cronjobs/rss/rss.pl uses HTP
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact:
URL:
Keywords:
: 10700 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-10-31 17:57 UTC by Jared Camins-Esakov
Modified: 2015-06-23 03:39 UTC (History)
12 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9000: the directory misc/cronjobs/rss/ has been removed (24.20 KB, patch)
2014-06-20 09:41 UTC, Yohann Dufour
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9000: the directory misc/cronjobs/rss/ has been removed (24.31 KB, patch)
2014-06-20 21:34 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9000: the directory misc/cronjobs/rss/ has been removed (24.42 KB, patch)
2014-06-21 16:18 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 9000 [1] - Update rss.pl to use Template Toolkit (6.48 KB, patch)
2014-07-28 14:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9000 [2] - Update included examples (20.83 KB, patch)
2014-07-28 14:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9000 [3] - Change conf key from tmpl to template (5.04 KB, patch)
2014-07-28 14:11 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9000 [4] - Update to GPL v3 (885 bytes, patch)
2014-07-28 14:12 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9000 [3] - Change conf key from tmpl to template (6.11 KB, patch)
2014-07-28 14:13 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9000 [4] - Update to GPL v3 (885 bytes, patch)
2014-07-28 14:13 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9000 [1] - Update rss.pl to use Template Toolkit (6.68 KB, patch)
2014-07-28 16:01 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9000 [2] - Update included examples (20.91 KB, patch)
2014-07-28 16:01 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9000 [3] - Change conf key from tmpl to template (6.18 KB, patch)
2014-07-28 16:01 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9000 [4] - Update to GPL v3 (958 bytes, patch)
2014-07-28 16:01 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 9000: Followup to fix tabs & closing TT directive (5.00 KB, patch)
2014-07-28 16:02 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9000 [1] - Update rss.pl to use Template Toolkit (6.74 KB, patch)
2014-07-28 19:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 9000 [2] - Update included examples (20.97 KB, patch)
2014-07-28 19:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 9000 [3] - Change conf key from tmpl to template (6.24 KB, patch)
2014-07-28 19:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 9000 [4] - Update to GPL v3 (1023 bytes, patch)
2014-07-28 19:22 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 9000: Followup to fix tabs & closing TT directive (5.08 KB, patch)
2014-07-28 19:22 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2012-10-31 17:57:02 UTC
The file check misc/cronjobs/rss/rss.pl uses HTML::Template::Pro. It should
be converted to use Template::Toolkit, or, if it is a legacy script, removed.
Comment 1 Owen Leonard 2012-10-31 18:05:36 UTC
I remember trying to work with this RSS feed generator years ago but I don't think it's used anymore. As far as I know misc/cronjobs/rss can be removed altogether.
Comment 2 Fridolin Somers 2012-12-05 14:14:00 UTC
(In reply to comment #1)
> I don't think it's used anymore.
No, it is used by several libraries we work for.
Comment 3 Chris Cormack 2012-12-05 19:53:47 UTC
Then it desperately needs to be fixed, because we don't want to keep it using HTML::Template::Pro
Comment 4 Fridolin Somers 2014-06-12 13:33:50 UTC
(In reply to Fridolin SOMERS from comment #2)
> (In reply to comment #1)
> > I don't think it's used anymore.
> No, it is used by several libraries we work for.

Sorry, I've checked and none of our libraries use this, I've mixed up with something else.
It can be removed.
Comment 5 Yohann Dufour 2014-06-16 11:59:31 UTC
Since misc/cronjobs/rss/rss.pl is not used anymore, it should be removed.
Moreover, this file contains old dependencies with the module HTML::Template::Pro.

For a new user of Koha, which launchs the test of t/db_dependent/00-strict.t , it prints :
t/db_dependent/00-strict.t ............................. 363/? 
#   Failed test 'Syntax check misc/cronjobs/rss/rss.pl'
#   at /usr/share/perl5/Test/Strict.pm line 394.
# Can't locate HTML/Template/Pro.pm in @INC (you may need to install the HTML::Template::Pro module) (@INC contains: installer misc/translator /home/yohann/koha /home/yohann/qa-test-tools /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl . /home/yohann/koha /home/yohann/qa-test-tools /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at misc/cronjobs/rss/rss.pl line 30.
# BEGIN failed--compilation aborted at misc/cronjobs/rss/rss.pl line 30.
Comment 6 Yohann Dufour 2014-06-20 09:41:43 UTC Comment hidden (obsolete)
Comment 7 Bernardo Gonzalez Kriegel 2014-06-20 21:34:54 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2014-06-21 15:19:47 UTC
*** Bug 10700 has been marked as a duplicate of this bug. ***
Comment 9 Katrin Fischer 2014-06-21 16:18:09 UTC
I am not entirely sure about removing these, as the feature seems still functional. I managed to create an XML file with the last Acquired records by installing HTP and running ./rss.pl lastAcquired.conf.

Of course there are a couple of problems: The generated XML file is currently only available in English, the feature depends on HTP. 

As the feature is separate to Koha and can easily be restored, I will pass QA.
Comment 10 Katrin Fischer 2014-06-21 16:18:41 UTC Comment hidden (obsolete)
Comment 11 Tomás Cohen Arazi 2014-07-10 17:10:20 UTC
A counter patch migut easily change the syntax and avoid loosing the feature that seems to be used by some libraries.
Comment 12 Kyle M Hall 2014-07-28 14:10:46 UTC Comment hidden (obsolete)
Comment 13 Kyle M Hall 2014-07-28 14:10:58 UTC Comment hidden (obsolete)
Comment 14 Kyle M Hall 2014-07-28 14:11:01 UTC Comment hidden (obsolete)
Comment 15 Kyle M Hall 2014-07-28 14:12:29 UTC Comment hidden (obsolete)
Comment 16 Kyle M Hall 2014-07-28 14:13:49 UTC Comment hidden (obsolete)
Comment 17 Kyle M Hall 2014-07-28 14:13:57 UTC Comment hidden (obsolete)
Comment 18 Martin Renvoize 2014-07-28 15:29:17 UTC
Cheers for this Kyle,

I've raised it with our guys to test and go forth and sign-off.

Martin
Comment 19 Bernardo Gonzalez Kriegel 2014-07-28 16:01:12 UTC Comment hidden (obsolete)
Comment 20 Bernardo Gonzalez Kriegel 2014-07-28 16:01:20 UTC Comment hidden (obsolete)
Comment 21 Bernardo Gonzalez Kriegel 2014-07-28 16:01:29 UTC Comment hidden (obsolete)
Comment 22 Bernardo Gonzalez Kriegel 2014-07-28 16:01:38 UTC Comment hidden (obsolete)
Comment 23 Bernardo Gonzalez Kriegel 2014-07-28 16:02:12 UTC Comment hidden (obsolete)
Comment 24 Martin Renvoize 2014-07-28 19:22:21 UTC
Created attachment 30229 [details] [review]
[PASSED QA] Bug 9000 [1] - Update rss.pl to use Template Toolkit

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Tested using script with sample conf files
RSS feeds generated are 'well formed' xml
Some koha-qa errors fixed in followup

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 25 Martin Renvoize 2014-07-28 19:22:29 UTC
Created attachment 30230 [details] [review]
[PASSED QA] Bug 9000 [2] - Update included examples

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 26 Martin Renvoize 2014-07-28 19:22:38 UTC
Created attachment 30231 [details] [review]
[PASSED QA] Bug 9000 [3] - Change conf key from tmpl to template

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 27 Martin Renvoize 2014-07-28 19:22:47 UTC
Created attachment 30232 [details] [review]
[PASSED QA] Bug 9000 [4] - Update to GPL v3

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 28 Martin Renvoize 2014-07-28 19:22:54 UTC
Created attachment 30233 [details] [review]
[PASSED QA] Bug 9000: Followup to fix tabs & closing TT directive

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 29 Martin Renvoize 2014-07-28 19:25:10 UTC
Happy to pass QA on this.. thanks so much for getting to this Kyle, and beating my team to sign-off Bernardo meaning I could QA.

I took the initiative of taking Bernardo's patch straight to QA as it was simply a white-space fix to make git not complain ;)

Go forth and push fair RM ;)
Comment 30 Tomás Cohen Arazi 2014-07-29 19:42:16 UTC
Patches pushed to master.

Thanks Kyle!!
Comment 31 Nicole C. Engard 2014-07-30 13:10:00 UTC
Hi all,

Can someone help me out here and tell me if/how this changes this section of the manual?

http://manual.koha-community.org/3.16/en/opacenhancedcontent.html#customrss

Thanks!
Nicole