Bug 9001 - zebraqueue_daemon is deprecated and must go
Summary: zebraqueue_daemon is deprecated and must go
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical
Assignee: Galen Charlton
QA Contact: Mason James
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-31 18:48 UTC by Jared Camins-Esakov
Modified: 2019-06-27 09:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 9001: Remove Zebraqueue_daemon (29.88 KB, patch)
2012-10-31 19:18 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 9001: Remove Zebraqueue_daemon (29.93 KB, patch)
2012-11-02 19:06 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2012-10-31 18:48:55 UTC

    
Comment 1 Jared Camins-Esakov 2012-10-31 19:18:34 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-11-02 19:06:33 UTC
Created attachment 13240 [details] [review]
Bug 9001: Remove Zebraqueue_daemon

[This patch was split out from tcohen's excellent patches for bug 8519
 --jcamins]

It removes the obsolete zebraqueue_daemon.pl and koha-zebraqueue-ctl.sh
obsolete scripts too.

Several files are modified to address te removal/addition of these files.

I didn't run the install procedure as I was working on my laptop with a dev
setup, just set the symlinks. Now fixed things as proposed by wajasu
on comment #4. Any other suggestion please let me know.

Tested to work on an up-to-date Ubuntu 12.04.

Asked by wajasu, remove remaining obsolete zebraqueue stuff.

Sponsored-by: Universidad Nacional de Córdoba

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Mason James 2012-11-06 21:28:26 UTC
(In reply to comment #2)
> Created attachment 13240 [details] [review]
> Bug 9001: Remove Zebraqueue_daemon
> 
> Sponsored-by: Universidad Nacional de Córdoba
> 
> Signed-off-by: wajasu <matted-34813@mypacks.net>
> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

patch looks good, passing QA...  
(great patch, well done!)


$ koha-qa.pl -c 1
testing 1 commit(s) (applied to 26f8859 'Bug 8872: Changes for intranet showm')

 9ace63b Bug 9001: Remove Zebraqueue_daemon
 - Makefile.PL
 - install_misc/install_koha_on_fresh_debian
 - misc/bin/koha-zebraqueue-ctl.sh
 - misc/bin/zebraqueue_daemon.pl
 - misc/cronjobs/zebraqueue_start.pl
 - t/Makefile
 - t/db_dependent/lib/KohaTest.pm

 * Makefile.PL                                                              OK
 * t/db_dependent/lib/KohaTest.pm                                           OK
Comment 4 Jared Camins-Esakov 2012-11-06 21:42:13 UTC
This patch has been pushed to master.
Comment 5 Paul Poulain 2012-11-08 16:31:42 UTC
Patch pushed to branch 3.10.x
Comment 6 Jared Camins-Esakov 2012-12-03 13:01:41 UTC
Sure enough, Zebraqueue_daemon is gone.