Bug 9008 - Warn if librarian logged-in with mysql/admin account
Summary: Warn if librarian logged-in with mysql/admin account
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks: 8221
  Show dependency treegraph
 
Reported: 2012-11-02 11:48 UTC by Paul Poulain
Modified: 2013-05-23 06:23 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9008: warn if user is logged-in with admin account (1.84 KB, patch)
2012-11-02 11:50 UTC, Paul Poulain
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9008: warn if user is logged-in with admin account (1.93 KB, patch)
2012-11-02 11:59 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 9008 [Follow-up] Warn if librarian logged-in with mysql/admin account (1.63 KB, patch)
2012-11-02 12:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9008 [Follow-up] Warn if librarian logged-in with mysql/admin account (1.65 KB, patch)
2012-11-04 08:21 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2012-11-02 11:48:16 UTC
When a librarian is logged-in with the mysql accounts, there are some features that are not working, mainly due to database referential integrity.

It should be clearly stated on the homepage of Koha that it's a bad idea
Comment 1 Paul Poulain 2012-11-02 11:50:47 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2012-11-02 11:59:03 UTC
Created attachment 13202 [details] [review]
[SIGNED-OFF] Bug 9008: warn if user is logged-in with admin account

Test plan:
* log-in staff interface with admin (mysql) account => there's a large warning on the homepage
* log-in with another account => nothing displayed

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 3 Owen Leonard 2012-11-02 12:34:40 UTC
There is a typo:

+        <div id="adminwarning"i class="alert">

That should be:

         <div id="adminwarning" class="dialog alert">

I also suggest wrapping "Warning:" in <strong>
Comment 4 Owen Leonard 2012-11-02 12:55:26 UTC Comment hidden (obsolete)
Comment 5 Chris Cormack 2012-11-04 08:21:58 UTC
Created attachment 13243 [details] [review]
Bug 9008 [Follow-up] Warn if librarian logged-in with mysql/admin account

- Correcting typo
- Adding markup tweaks
- Adjusting the wording of the warning

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 6 Jonathan Druart 2012-11-05 11:19:59 UTC
Simple patch. 
It adds a warning message if the logged-in user is the admin account.

Marked as Passed QA.
Comment 7 Jared Camins-Esakov 2012-11-23 16:53:40 UTC
This patch has been pushed to master.
Comment 8 Chris Cormack 2012-11-26 00:36:38 UTC
Pushed to 3.10.x will be in 3.10.1