Bug 9013 - Cart in staff interface displays location pulled from Description (OPAC)
Summary: Cart in staff interface displays location pulled from Description (OPAC)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-06 18:25 UTC by Elaine Bradtke
Modified: 2015-06-04 23:33 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Example of location codes where staff and OPAC displays differ (39.79 KB, image/tiff)
2012-11-06 18:25 UTC, Elaine Bradtke
Details
Bug 9013 - Cart in staff interface displays location pulled from Description (OPAC) (1.65 KB, patch)
2014-07-16 17:11 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 9013 - Cart in staff interface displays location pulled from Description (OPAC) (1.67 KB, patch)
2014-08-09 04:43 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
[PASSED QA] Bug 9013 - Cart in staff interface displays location pulled from Description (OPAC) (1.75 KB, patch)
2014-08-10 16:16 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Elaine Bradtke 2012-11-06 18:25:02 UTC
Created attachment 13271 [details]
Example of location codes where staff and OPAC displays differ

Koha allows us to display authorized values for Location in two different ways, one for the OPAC one for the staff interface. 
The Cart in the staff interface should display the locations that ordinarily display in the staff interface.  But it seems to be pulling the location information from the Display (OPAC) line.  
In the example attached the staff location descriptions are much more specific, enabling staff to retrieve material from the correct storage location.  In the OPAC these are marked 'storage'
When staff use the Cart function to create a list of items to retrieve, they need the specific location, which is normally available in Staff interface, but unfortunately all they get is the OPAC version of this information.
Comment 1 Owen Leonard 2014-07-16 17:11:53 UTC Comment hidden (obsolete)
Comment 2 Nick Clemens (kidclamp) 2014-08-09 04:43:41 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-10 16:16:10 UTC
Created attachment 30662 [details] [review]
[PASSED QA] Bug 9013 - Cart in staff interface displays location pulled from Description (OPAC)

When the cart in the staff client pulls description data for
items.location and items.ccode it pulls the value designated for the
OPAC--probably a cut-and-paste error when the feature was added to the
staff client.

This patch removes the 'opac' parameter from GetKohaAuthorisedValues.

To test you must have at least one LOC authorized value configured to
have different descriptions for staff and OPAC. Locate or edit an item
with that shelving location and add that record to the cart in the staff
client.

When you view the cart, the shelving location description in the "Items"
column should show the description for the staff client, not the OPAC.

Signed-off-by: Nick Clemens <nick@debian>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.
Comment 4 Tomás Cohen Arazi 2014-08-11 18:57:16 UTC
Patch pushed to master.

Thanks Owen!