Bug 9025 - Add new icons for item types
Summary: Add new icons for item types
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Galen Charlton
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-07 17:47 UTC by Sophie MEYNIEUX
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9025 : Adding new icons for itemtypes from Sudoc (49.71 KB, patch)
2012-11-07 17:51 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
[Signed off] Bug 9025 : Adding new icons for itemtypes from Sudoc (49.77 KB, patch)
2012-11-08 01:13 UTC, Melia Meggs
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9025: Adding new icons for itemtypes from Sudoc (49.99 KB, patch)
2012-11-25 20:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie MEYNIEUX 2012-11-07 17:47:43 UTC
Some of our clients want to use Sudoc icons for item types (http://www.abes.fr/Sudoc/Boite-a-outils-Sudoc-public/Les-icones-Sudoc).
This patch provides the files that allow you to choose them when you define your itemtypes.
Comment 1 Sophie MEYNIEUX 2012-11-07 17:51:28 UTC Comment hidden (obsolete)
Comment 2 Sophie MEYNIEUX 2012-11-07 18:00:49 UTC
With this patch applied, when you define (or modify) an item type, in "choose an icon" you've got a new tab called "sudoc" with Sudoc icons in it
Comment 3 Melia Meggs 2012-11-08 01:13:57 UTC Comment hidden (obsolete)
Comment 4 Melia Meggs 2012-11-08 01:15:11 UTC
After applying the patch, I can see the Sudoc icons when creating a new item type or modifying an existing item type.  I was able to choose a Sudoc icon with no problem.  Signing off!
Comment 5 Katrin Fischer 2012-11-25 20:32:20 UTC
Created attachment 13658 [details] [review]
[SIGNED-OFF] Bug 9025: Adding new icons for itemtypes from Sudoc

Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked that new images show up when managing itemtypes and
authorised values and can be selected and used.
Checked about page for license information.
All tests pass.
Comment 6 Jared Camins-Esakov 2012-11-25 23:52:08 UTC
This patch has been pushed to master.
Comment 7 Jared Camins-Esakov 2013-03-17 11:50:07 UTC
The Sudoc icons seem to be licensed CC-BY-NC-SA. If that is the case, I will need to revert them out of the Koha codebase before the release. Could an expert French speaker please confirm this with ABES?
Comment 8 Jared Camins-Esakov 2013-03-18 14:06:52 UTC
This has been reverted from master due to the licensing issues. Marking RESOLVED-WONTFIX since the Sudoc icons cannot be included in Koha.