Some libraries with a high number of items per record sometimes want to modify a batch of items (not all items of this record at once). So this development add a checkboxes column for selecting items and trigger actions on them (currently only batch deletion and batch modification). With bug 9034, this will allow filtering -> selecting -> batch processing items of a record quite quickly.
Created attachment 13344 [details] [review] Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions.
Created attachment 13513 [details] [review] Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions.
Created attachment 13933 [details] [review] Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Please resolve merge conflict on template.
Created attachment 14737 [details] [review] [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) Rebased on master
Owen, Could I have your opinion on this patch please? Do you think it is a good idea to remove actions for items (delete and edit) from the toolbar?
(In reply to comment #6) > Do you think it is a good idea to remove actions for items (delete and edit) > from the toolbar? I don't think it's a good idea. I think there's no reason not to remove an option which may be in use by Koha users, and for those who want to quickly edit or delete all items it is fewer clicks than manually selecting from the table of holdings. Other minor changes I would like to see: - Adding a blank option to the "action" menu so that (at least in English) "Delete selected items" isn't the default. - Add a "for" attribute to the "Action" label to make it clickable. - Add a label to the "Open in new window" text to make it clickable. Those could be handled in a follow-up, but I wouldn't like to see this pushed with the toolbar button options missing.
Julian, could you take care of Owen's comments please? Thx!
Created attachment 16612 [details] [review] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes
Created attachment 16707 [details] [review] [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) Rebased
Created attachment 16708 [details] [review] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Rebased
Patch tested with a sandbox, by Pierre Angot et Leila Arkab <tredok.pierre@gmail.com>
Created attachment 16711 [details] [review] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre@gmail.com>
Hm, testing this I have am a little worried about a few things in this approach: 1) These patches remove the batch edit and delete options from the Edit menu, but the system preference added is by default off. So we actually take away a feature with the update. 2) The interface seems not quite right to me. Instead of having to select an option from a pull down and then click on go, I think having 2 links instead would save one click and be less fiddly. 3) The first column has the little arrow for sorting, but sorting doesn't work, whether you have seleted checkboxes or not. Also if you activate the filters, it has an added search box that doesn't make sense for this column. Failing for 1) and 3). My personal opinion is that it would be nice to deal with it like with the "activate filters" option. So it's not a "all or nothing" option using the system preference as only switch, but also something people can choose to activate easily on demand.
5) Oh, before I forget: I had added the bug number to the database update when fixing the conflicts. Please add it when you do a follow-up.
Created attachment 19060 [details] [review] Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
(In reply to comment #14) > Hm, testing this I have am a little worried about a few things in this > approach: > > 1) These patches remove the batch edit and delete options from the Edit > menu, but the system preference added is by default off. So we actually take > away a feature with the update. > > 2) The interface seems not quite right to me. Instead of having to select an > option from a pull down and then click on go, I think having 2 links instead > would save one click and be less fiddly. > > 3) The first column has the little arrow for sorting, but sorting doesn't > work, whether you have seleted checkboxes or not. Also if you activate the > filters, it has an added search box that doesn't make sense for this column. > > Failing for 1) and 3). 1 and 3 fixed with the qa followup. For 2, the idea is to add others actions in this drop-down list. So it will be difficult to deal with more than 2 links. Back to Signed Off
What other actions do you have in mind? I think unless we really have another idea there would be no reason to overcomplicate the interface. Maybe we could ask Owen nicely to take a look.
(In reply to comment #18) > What other actions do you have in mind? No one for now :)
I think change the display when we actually have more options :)
Created attachment 19344 [details] [review] Bug 9044: Change dropdown list into links list
Note that links are rebuild each time a checkbox is changed, so actions links point to valid URL and can be opened in a new window if your browser permit it (right click -> open in a new window)
Applying: Bug 9044: Provide item selection in record detail page (staff client) Applying: Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Applying: Bug 9044: QA followup fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9044: QA followup
Created attachment 19913 [details] [review] [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client)
Created attachment 19914 [details] [review] [SIGNED-OFF] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre@gmail.com>
Created attachment 19915 [details] [review] [SIGNED-OFF] Bug 9044: QA followup
Created attachment 19916 [details] [review] Bug 9044: Change dropdown list into links list
All patches rebased on master.
Applying: Bug 9044: Provide item selection in record detail page (staff client) Using index info to reconstruct a base tree... M catalogue/detail.pl M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging catalogue/detail.pl Patch failed at 0001 Bug 9044: Provide item selection in record detail page (staff client) The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
Created attachment 21324 [details] [review] [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 21325 [details] [review] [SIGNED-OFF] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre@gmail.com>
Created attachment 21326 [details] [review] [SIGNED-OFF] Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 21327 [details] [review] Bug 9044: Change dropdown list into links list
All patches rebased on master
Patch applied cleanly, go forth and signoff
Created attachment 21561 [details] [review] [SIGNED-OFF] Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 21562 [details] [review] [SIGNED-OFF] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 21563 [details] [review] [SIGNED-OFF] Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Created attachment 21564 [details] [review] [SIGNED-OFF] Bug 9044: Change dropdown list into links list Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> That's the one I sign. Comment: At first I don't know where to find links, until I selected an item. Works as described. No koha-qa errors. Solved merge conflict on updatedatabase.pl
Created attachment 21591 [details] Screnshot, search filters for materials and barcode are broken. I think this is very close to ready, but there is a problem with the search filters (see screenshot).
I verified the search filters show correctly for all columns on master. Apart from that I found no problems - also tested with SeparateHoldings and SeparateHoldingsBranch. Please provide a follow-up!
Created attachment 21634 [details] [review] Bug 9044: Set the number of filters according to number of columns
Simple patch, easy to signoff :)
Created attachment 21683 [details] [review] [SIGNED-OFF] Bug 9044: Set the number of filters according to number of columns Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Filters now shows correctly. No errors
Created attachment 21745 [details] [review] [PASSED QA] Bug 9044: Provide item selection in record detail page (staff client) This patch add a column in the items table of catalogue/detail.pl that contains checkboxes for item selection and a drop-down list of actions that can be executed for the selection of items. Currently available actions are: - Delete selected items: redirect to batch items deletion - Modify selected items: redirect to batch items modification These actions replace the two menu entries corresponding to the same action. Item selection is only enabled if the new syspref StaffDetailItemSelection is ON. Actions are not displayed if user doesn't have the right permissions. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Further testing notes on last patch. http://bugs.koha-community.org/show_bug.cgi?id=9055
Created attachment 21746 [details] [review] [PASSED QA] Bug 9044 [Follow-up] Add a blank option + add missing 'for' attributes Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre@gmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 21747 [details] [review] [PASSED QA] Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 21748 [details] [review] [PASSED QA] Bug 9044: Change dropdown list into links list Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> That's the one I sign. Comment: At first I don't know where to find links, until I selected an item. Works as described. No koha-qa errors. Solved merge conflict on updatedatabase.pl Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 21749 [details] [review] [PASSED QA] Bug 9044: Set the number of filters according to number of columns Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Filters now shows correctly. No errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. This feature is a little controversial as it removes the batch edit/delete options from the menu and moves them to the item table, additionally controlled by a system preference. Maybe later on, we can think about the UI a bit more, but it works nicely. Tested with. - SeparateHoldings and SeparateHoldingsBranch activated/deactivated. - Search filters. - None, both, or one of the permissions.
Pushed to master. Thanks Julian! I also pushed a follow-up that adds the toolbar menu items back. From the commit message: My rationale: the question of the best UI for selecting items for batch operations is not yet settled. Adding the ability to select items from the bib details page is indeed useful, but as currently implemented, it can hide the availability of the batch edit/deletion operations if no item is yet selected. Although having both the toolbar items and the links that display when an item is selected is a bit redundant, for now I think we can live with that until we get more eyes on the UI.