Created attachment 13375 [details] [review] Bug 9053: Test::MockModule and DBD::Mock should be required Test::MockModule and DBD::Mock are required for the unit tests in t/ to run. This is good, but means they should be required.
Created attachment 13379 [details] [review] Bug 9053: Test::MockModule and DBD::Mock should be required Test::MockModule and DBD::Mock are required for the unit tests in t/ to run. This is good, but means they should be required. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
QA comment: The patch is correct but I don't understand where stands the boundary between "required" and "not required". What is the idea behind this patch? To me, launching tests is not useful for a fonctionnal use of Koha. If these 2 modules are required perhaps should we add the others Test::* as required, too?
(In reply to comment #3) > QA comment: > > The patch is correct but I don't understand where stands the boundary > between "required" and "not required". What is the idea behind this patch? > > To me, launching tests is not useful for a fonctionnal use of Koha. > If these 2 modules are required perhaps should we add the others Test::* as > required, too? These two modules are required for the tests in t/ to pass -- which is reasonable -- and running the tests in t/ is part of the installation process. I don't know that it's necessary to make all Test modules required, though I don't know that there's any reason *not* to make all Test modules required. Installing the Test modules is not a great hardship, and I'd rather new users know if there's a problem with the version of Koha that they're installing.
(In reply to comment #4) > These two modules are required for the tests in t/ to pass -- which is > reasonable -- and running the tests in t/ is part of the installation > process. I don't know that it's necessary to make all Test modules required, > though I don't know that there's any reason *not* to make all Test modules > required. Installing the Test modules is not a great hardship, and I'd > rather new users know if there's a problem with the version of Koha that > they're installing. Thanks for your answer. Marked as Passed QA.
This patch has been pushed to master.
Patch pushed to branch 3.10.x
Released in 3.10.0