In table language_descriptions a lot of translations are missing (with the exception of French) See http://irc.koha-community.org/irclog/koha/2012-11-11#i_1125026 Additions need to be added to subtag_registry.sql (for new installs) and to updatedatabase.pl (for upgrading). Patch will follow to add German (and a couple of French) translations to the table. This Bug could be used as 'omnibus' for follow ups for other languages.
Created attachment 13382 [details] [review] Bug 9056 - Add more translations to table language_descriptions In table language_descriptions a lot of translations are missing (with the exception of French) Additions need to be added to subtag_registry.sql (for new installs) and to updatedatabase.pl (for upgrading). This Bug could be used as 'omnibus' for follow ups for other languages. This patch adds German (and some missing French) translations. Tested updatedatabase.pl Would appreciate if somebody could test subtag_registry.sql.
Created attachment 13503 [details] [review] [SIGNED-OFF] Bug 9056 - Add more translations to table language_descriptions In table language_descriptions a lot of translations are missing (with the exception of French) Additions need to be added to subtag_registry.sql (for new installs) and to updatedatabase.pl (for upgrading). This Bug could be used as 'omnibus' for follow ups for other languages. This patch adds German (and some missing French) translations. Tested updatedatabase.pl Would appreciate if somebody could test subtag_registry.sql. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested both, the updatedatabase and the sql file. Works well.
Hi Marc, you changed only the en file - I think we need a follow up adding this to the subtag_registry.sql files in the other language directories. At the moment your translations will not get installed using the German installer.
From IRC: http://irc.koha-community.org/irclog/koha/2012-11-20#i_1129863 (...) Bug 8954 adds the functionallity to display the languages correctly in opac-search.pl and search.pl and Bug 9056 provides the information in the table language_descriptions. (Not all language names are translated into all langages) (...) We have the problem that the file subtag_registry.sql should be distributed to all installer folders (installer/data/mysql/[LANGUAGE]/mandatory), or the installer should always take it from installer/data/mysql/en/mandatory
QA comment: * the C4/Languages.pm is really ugly, as it does a lot of SQL queries for each page (120 queries ?) I feel/fear that this patch will add a number of additional queries, slowing Koha more and more. And a complete patch would be a nightmare. * no other QA comment, this patch is a needed addition, not really an ENH (i changed the severity to minor) passed QA
Created attachment 13989 [details] [review] Bug 9056 - Add more translations to table language_descriptions In table language_descriptions a lot of translations are missing (with the exception of French) Additions need to be added to subtag_registry.sql (for new installs) and to updatedatabase.pl (for upgrading). This Bug could be used as 'omnibus' for follow ups for other languages. This patch adds German (and some missing French) translations. Tested updatedatabase.pl Would appreciate if somebody could test subtag_registry.sql. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested both, the updatedatabase and the sql file. Works well.
This patch has been pushed to master.
We still need a follow up for this adding the languages to the other translations.
Hi, could someone take a look at Bug 12017
(In reply to Katrin Fischer from comment #8) > We still need a follow up for this adding the languages to the other > translations. On current master there is only one file for this. I completed all languages/scripts/regions on Bug 12250, but can add patches for 3.16/14/12 if needed. Not sure about the status of this bug
I think we can close it :) If someone wants a complete file for the earlier versions, we can then deal with it.