Created attachment 13407 [details] screenshot On the vendor summary and vendor edit screen tax and discount percentages are fomratted differently.
Created attachment 13408 [details] screenshot
Created attachment 14641 [details] [review] bug 9062 Fix format for discount rate for vendors On the vendor display and edit screens, the tax rate information was formatted to 1 decimal point, while the discount rate was not. This patch adds a format string to the discount information so that it is formatted in the same way. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz>
Created attachment 14642 [details] [review] bug 9062 Fix format for discount rate for vendors On the vendor display and edit screens, the tax rate information was formatted to 1 decimal point, while the discount rate was not. This patch adds a format string to the discount information so that it is formatted in the same way. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Actually, would this need changing for other languages? or is that done by translators? I only have an en directory.
That's done by the translation scripts, they build other directories from the .po files. So all good.
Created attachment 14643 [details] [review] bug 9062 Fix spacing next to tax rate On the supplier view screen, there was a space after the discount and before the % sign, but there was none for the tax rate. This patch adds in a patch, so they look similar. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz>
Created attachment 14644 [details] [review] bug 9062 Fix spacing next to tax rate On the supplier view screen, there was a space after the discount and before the % sign, but there was none for the tax rate. This patch adds in a patch, so they look similar. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Just wondering whether the number of decimal points for the discount feild should be 1 or 2, it is shown as 2 in some other places, but my patch puts it to 1 here.
Actually that is a good question ... 2 I think probably makes more sense. Any other opinions? It's for percentages right? 2dp makes sense to me for that
Yeh, and then most of the Tax percentages I've seen are just 1dp
I think even if there is some need for discussion about how many decimals should be shown, those patches are nice little improvments to consistency.
Created attachment 14686 [details] [review] [SIGNED-OFF] Bug 9062 Fix format for discount rate for vendors On the vendor display and edit screens, the tax rate information was formatted to 1 decimal point, while the discount rate was not. This patch adds a format string to the discount information so that it is formatted in the same way. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Makes display on vendor detail page more consistent and passes all tests.
Created attachment 14687 [details] [review] [SIGNED-OFF] Bug 9062 Fix spacing next to tax rate On the supplier view screen, there was a space after the discount and before the % sign, but there was none for the tax rate. This patch adds in a patch, so they look similar. Signed-off-by: Hugh Davenport <hugh@davenport.net.nz> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tiny follow-up, fixes spacing.
This patch has been pushed to master. Welcome to our newest developer!
Pushed to 3.10.x, will be in 3.10.3 release