Searching for autorities in "Home › Authorities" works fine but doing the same search in the tag editor for the 650 field (marc21) gives this error: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. Here's the URL of the page showing the error: http://example.com:8080/cgi-bin/koha/authorities/auth_finder.pl?op=do_search&type=intranet&index=tag_650_subfield_a_214074_10477&authtypecode=TOPIC_TERM&marclist=mainmainentry&and_or=and&operator=contains&value_mainstr=Common+Cold+&marclist=mainentry&and_or=and&operator=contains&marclist=any&and_or=and&operator=contains&marclist=match&and_or=and&operator=contains&orderby=HeadingAsc
Created attachment 13438 [details] [review] Bug 9070: authority searches in auth_finder error out GetAuthType returns a hash and not a reference to a hash. When you try to treat a regular hash like a reference, as is the case in auth_finder when using authority records imported into Koha from elsewhere, bad things happen. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off.
Created attachment 13439 [details] [review] Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out GetAuthType returns a hash and not a reference to a hash. When you try to treat a regular hash like a reference, as is the case in auth_finder when using authority records imported into Koha from elsewhere, bad things happen. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised.
Created attachment 13440 [details] [review] Bug 9070: authority searches in auth_finder error out When using authority records imported into Koha from elsewhere, you can get an error like: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. in authorities/auth_finder.pl. This patch fixes that error. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off.
Created attachment 13441 [details] [review] Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out When using authority records imported into Koha from elsewhere, you can get an error like: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. in authorities/auth_finder.pl. This patch fixes that error. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. No warning about "defined(%hash) is deprecated" under perl v5.10.1.
QA comment : * passes koha-qa.pl * works as advertised * no string changes passed QA
Created attachment 13553 [details] [review] Bug 9070: [SIGNED-OFF] authority searches in auth_finder error out When using authority records imported into Koha from elsewhere, you can get an error like: Can't use string ("HASH(0xbc6c{30)") as a HASH ref while "strict refs" in use at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 363. in authorities/auth_finder.pl. This patch fixes that error. To test: 1) You will need records imported from elsewhere. 2) Use the authority control plugin in a bib record to search for one of those headings. 3) Observe you get a nasty error. 4) Apply patch. 5) Repeat step 2. 6) Observe the error is gone. 7) Sign off. Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. No warning about "defined(%hash) is deprecated" under perl v5.10.1. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch has been pushed to master.
This patch is in 3.10.x and 3.8.x (was in 3.10.0 release will be 3.8.8)