Bug 9104 - country in CSV in overdue_notices.pl
Summary: country in CSV in overdue_notices.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-19 13:20 UTC by Fridolin Somers
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.11 KB, patch)
2012-11-19 13:23 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 9104: country in CSV headers in overdue_notices.pl (2.21 KB, patch)
2012-11-21 13:42 UTC, Kyle M Hall
Details | Diff | Splinter Review
Proposed patch (revisited) (3.19 KB, patch)
2012-12-03 09:14 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9104: country in CSV in overdue_notices.pl (3.24 KB, patch)
2012-12-07 13:59 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9104: country in CSV in overdue_notices.pl (3.66 KB, patch)
2012-12-16 21:01 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2012-11-19 13:20:27 UTC
When using overdue_notices.pl to generate a CSV file, the headers contain 'country' but data lines does not contain it.
Seems that borrower country is never used in this script.
Comment 1 Fridolin Somers 2012-11-19 13:23:23 UTC Comment hidden (obsolete)
Comment 2 Fridolin Somers 2012-11-19 13:25:11 UTC
This patch and Bug 9103 patch edits some same lines.
So first integrated will cause other rebase of the other.
Comment 3 Kyle M Hall 2012-11-21 13:42:45 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2012-12-01 23:32:36 UTC
I am not sure removing country is the right way to go. If you are using the overdues CSV file to create printed overdue notices, it's information you need for a complete address.
Comment 5 Fridolin Somers 2012-12-03 09:14:47 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2012-12-07 13:59:37 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2012-12-16 21:01:14 UTC
Created attachment 14160 [details] [review]
[SIGNED-OFF] Bug 9104: country in CSV in overdue_notices.pl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Output of of the overdues script with -csv now contains country
from the first address in the patron account.

I checked output for 2 patrons, one with and one without country
in the patron's address.

All tests pass. Perlcritic fails before and after:
"require" statement with library name as string at line 29, column 12.
Use a bareword instead.  (Severity: 5)
Comment 8 Jared Camins-Esakov 2012-12-19 13:09:30 UTC
This patch has been pushed to master.
Comment 9 Chris Cormack 2013-02-14 21:09:47 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10