If you're using the batch modification tool and entering a call number like E+ 123 ABC The tool removes the + and puts a space in it's place E 123 ABC
This is in Master and 3.8
I'm on a patch. See http://stackoverflow.com/questions/1373414/ajax-post-and-plus-sign-how-to-encode And http://www.w3schools.com/jsref/jsref_encodeuricomponent.asp
Created attachment 19245 [details] [review] Proposed patch See commit comment. (very tricky bug :D )
Created attachment 19288 [details] [review] Bug 9113 - batch modification removes + If you're using the batch modification tool and entering a call number like "E+ 123 ABC", the tool removes the + and puts a space in it's place "E 123 ABC" This is because form is posted via Ajax by background-job-progressbar.js. Values are URI-encoded using escape() javascript but this method does not escape some caracters : * @ - _ + . / And a + is considered as a space in a URI. This patch replaces escape() by encodeURIComponent() which encodes every character. Test plan : Perform an items batch modification by setting '* @ - _ + . /' in a field (notes for example) and see that all caracters are well saved. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 19407 [details] [review] Bug 9113 - batch modification removes + If you're using the batch modification tool and entering a call number like "E+ 123 ABC", the tool removes the + and puts a space in it's place "E 123 ABC" This is because form is posted via Ajax by background-job-progressbar.js. Values are URI-encoded using escape() javascript but this method does not escape some caracters : * @ - _ + . / And a + is considered as a space in a URI. This patch replaces escape() by encodeURIComponent() which encodes every character. Test plan : Perform an items batch modification by setting '* @ - _ + . /' in a field (notes for example) and see that all caracters are well saved. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Fridolyn!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn!
Pushed to 3.10.x, will be in 3.10.10
Pushed to 3.8.x, will be in 3.8.17