When putting documents in a basket, opening the basket and placing holds on them, everything happens in the basket pop-up window. We are redirected to reservation confirmation, and then to the holds list : which leads to a new window with the whole opac, leaving the user with the possibility of opening endless windows. The window should be closed when placing the holds.
Created attachment 13555 [details] [review] Bug 9115 - basket window should close automatically when placing a hold If you choose to place a hold from the Cart pop-up, the entire holds process (possibly including login) takes place in the cart window. Upon completion of the operation you're left with a second window which has lost its context as the Cart. This patch revises the hold process so that when you click the hold link in the cart the operation is moved to the main window and the Cart window closes. Since the holdSel() function doesn't require interaction with template variables I have moved it to basket.js along with the described changes. To test, put items in your Cart and open it. Select items to place on hold and click the "Place hold" link. The cart should close, and the items you selected should appear on the place hold screen in the main window.
It doesn't seem to work. Using firefox 16.0.2 nothing seems to happen when i click "place hold" from the cart window. With Chromium version 20.0.1132.47, i am still redirected to the login form, or the holds list if i am already connected, within the cart window.
(In reply to comment #2) > With Chromium version 20.0.1132.47, i am still redirected to the login form, > or the holds list if i am already connected, within the cart window. Talking to Gaetan on IRC we've determined the Firefox problem was a caching problem. I don't have any problem with it in Chrome (or Chromium, or IE, or Opera), so hopefully a follow-up test will confirm.
I am using Chrome in Kubuntu, and I also get no action when I click the "Place hold" link.
Created attachment 13585 [details] [review] Bug 9115 - basket window should close automatically when placing a hold If you choose to place a hold from the Cart pop-up, the entire holds process (possibly including login) takes place in the cart window. Upon completion of the operation you're left with a second window which has lost its context as the Cart. This patch revises the hold process so that when you click the hold link in the cart the operation is moved to the main window and the Cart window closes. Since the holdSel() function doesn't require interaction with template variables I have moved it to basket.js along with the described changes. To test, put items in your Cart and open it. Select items to place on hold and click the "Place hold" link. The cart should close, and the items you selected should appear on the place hold screen in the main window. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Clearing my cache caused the patch to behave properly. My bad! Works as advertised.
Created attachment 13659 [details] [review] [SIGNED-OFF] Bug 9115 - basket window should close automatically when placing a hold If you choose to place a hold from the Cart pop-up, the entire holds process (possibly including login) takes place in the cart window. Upon completion of the operation you're left with a second window which has lost its context as the Cart. This patch revises the hold process so that when you click the hold link in the cart the operation is moved to the main window and the Cart window closes. Since the holdSel() function doesn't require interaction with template variables I have moved it to basket.js along with the described changes. To test, put items in your Cart and open it. Select items to place on hold and click the "Place hold" link. The cart should close, and the items you selected should appear on the place hold screen in the main window. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked in Firefox and Chromium in Ubuntu, works nicely. All tests pass.
This patch has been pushed to master.
Pushed to 3.10.x, will be in 3.10.1
Pushed to 3.8.x, will be in 3.8.8
Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. Thanks!
Created attachment 14003 [details] [review] Bug 9115 [3.6.x] basket window should close automatically when placing a hold If you choose to place a hold from the Cart pop-up, the entire holds process (possibly including login) takes place in the cart window. Upon completion of the operation you're left with a second window which has lost its context as the Cart. This patch revises the hold process so that when you click the hold link in the cart the operation is moved to the main window and the Cart window closes. Since the holdSel() function doesn't require interaction with template variables I have moved it to basket.js along with the described changes. To test, put items in your Cart and open it. Select items to place on hold and click the "Place hold" link. The cart should close, and the items you selected should appear on the place hold screen in the main window.
Just a bump for Liz
Patch tested with a sandbox, by caroline very-mathieu <caroline.very-mathieu@nimes-ville.fr>
Created attachment 16260 [details] [review] Revert "Merge branch 'bug_9025' into 3.12-master" This reverts commit 081e1ba4c31151db8a3c52a8daa96931a5ac544f, reversing changes made to 7e25faace8d70c2e81272cb3eacd41fa7215719d. Signed-off-by: caroline very-mathieu <caroline.very-mathieu@nimes-ville.fr>
This patch is already in master, it is for 3.6 branch. It cannot be test on a sandbox.
Created attachment 17398 [details] [review] Bug 9115 [3.6.x] basket window should close automatically when placing a hold If you choose to place a hold from the Cart pop-up, the entire holds process (possibly including login) takes place in the cart window. Upon completion of the operation you're left with a second window which has lost its context as the Cart. This patch revises the hold process so that when you click the hold link in the cart the operation is moved to the main window and the Cart window closes. Since the holdSel() function doesn't require interaction with template variables I have moved it to basket.js along with the described changes. To test, put items in your Cart and open it. Select items to place on hold and click the "Place hold" link. The cart should close, and the items you selected should appear on the place hold screen in the main window. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This patch works, but I'm wonder if parent.opener.document.location should be window.opener.document.location I cannot find any references to using the former on the web, but the latter appears to be commonplace and standard.
Moving this one to the next queue: Liz, apparently someone wants this in 3.6.
And from there to Pushed to Stable?