Bug 9115 - [3.6.X] basket window should close automatically when placing a hold
Summary: [3.6.X] basket window should close automatically when placing a hold
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-20 14:44 UTC by Gaetan Boisson
Modified: 2014-05-26 21:04 UTC (History)
9 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9115 - basket window should close automatically when placing a hold (2.77 KB, patch)
2012-11-20 14:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9115 - basket window should close automatically when placing a hold (2.83 KB, patch)
2012-11-21 14:20 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9115 - basket window should close automatically when placing a hold (2.90 KB, patch)
2012-11-25 20:48 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 9115 [3.6.x] basket window should close automatically when placing a hold (2.65 KB, patch)
2012-12-11 16:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Revert "Merge branch 'bug_9025' into 3.12-master" (50.06 KB, patch)
2013-03-18 15:05 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 9115 [3.6.x] basket window should close automatically when placing a hold (2.66 KB, patch)
2013-04-12 15:45 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Gaetan Boisson 2012-11-20 14:44:39 UTC
When putting documents in a basket, opening the basket and placing holds on them, everything happens in the basket pop-up window. We are redirected to reservation confirmation, and then to the holds list : which leads to a new window with the whole opac, leaving the user with the possibility of opening endless windows.

The window should be closed when placing the holds.
Comment 1 Owen Leonard 2012-11-20 14:56:29 UTC Comment hidden (obsolete)
Comment 2 Gaetan Boisson 2012-11-20 15:15:40 UTC
It doesn't seem to work.

Using firefox 16.0.2 nothing seems to happen when i click "place hold" from the cart window.

With Chromium version 20.0.1132.47, i am still redirected to the login form, or the holds list if i am already connected, within the cart window.
Comment 3 Owen Leonard 2012-11-20 16:39:52 UTC
(In reply to comment #2)
> With Chromium version 20.0.1132.47, i am still redirected to the login form,
> or the holds list if i am already connected, within the cart window.

Talking to Gaetan on IRC we've determined the Firefox problem was a caching problem. I don't have any problem with it in Chrome (or Chromium, or IE, or Opera), so hopefully a follow-up test will confirm.
Comment 4 Kyle M Hall 2012-11-21 13:31:05 UTC
I am using Chrome in Kubuntu, and I also get no action when I click the "Place hold" link.
Comment 5 Kyle M Hall 2012-11-21 14:20:18 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2012-11-21 14:21:26 UTC
Clearing my cache caused the patch to behave properly. My bad!

Works as advertised.
Comment 7 Katrin Fischer 2012-11-25 20:48:09 UTC Comment hidden (obsolete)
Comment 8 Jared Camins-Esakov 2012-11-25 23:17:02 UTC
This patch has been pushed to master.
Comment 9 Chris Cormack 2012-11-26 06:46:26 UTC
Pushed to 3.10.x, will be in 3.10.1
Comment 10 Chris Cormack 2012-11-26 07:53:17 UTC
Pushed to 3.8.x, will be in 3.8.8
Comment 11 Liz Rea 2012-11-28 01:38:10 UTC
Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. 

Thanks!
Comment 12 Owen Leonard 2012-12-11 16:05:37 UTC Comment hidden (obsolete)
Comment 13 Chris Cormack 2012-12-29 09:23:13 UTC
Just a bump for Liz
Comment 14 Paul Poulain 2013-03-18 15:04:46 UTC
Patch tested with a sandbox, by caroline very-mathieu <caroline.very-mathieu@nimes-ville.fr>
Comment 15 Paul Poulain 2013-03-18 15:05:09 UTC Comment hidden (obsolete)
Comment 16 Jonathan Druart 2013-03-18 15:58:34 UTC
This patch is already in master, it is for 3.6 branch.
It cannot be test on a sandbox.
Comment 17 Kyle M Hall 2013-04-12 15:45:22 UTC
Created attachment 17398 [details] [review]
Bug 9115 [3.6.x] basket window should close automatically when placing a hold

If you choose to place a hold from the Cart pop-up, the entire
holds process (possibly including login) takes place in the cart
window. Upon completion of the operation you're left with a second
window which has lost its context as the Cart.

This patch revises the hold process so that when you click the
hold link in the cart the operation is moved to the main window
and the Cart window closes.

Since the holdSel() function doesn't require interaction with
template variables I have moved it to basket.js along with the
described changes.

To test, put items in your Cart and open it. Select items to
place on hold and click the "Place hold" link. The cart
should close, and the items you selected should appear on the
place hold screen in the main window.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 18 Kyle M Hall 2013-04-12 15:47:31 UTC
This patch works, but I'm wonder if parent.opener.document.location should be window.opener.document.location

I cannot find any references to using the former on the web, but the latter appears to be commonplace and standard.
Comment 19 Marcel de Rooy 2013-04-15 12:05:44 UTC
Moving this one to the next queue: Liz, apparently someone wants this in 3.6.
Comment 20 Marcel de Rooy 2013-04-15 12:06:09 UTC
And from there to Pushed to Stable?