- Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table)
Created attachment 13560 [details] [review] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table)
Created attachment 13578 [details] [review] [SIGNED-OFF] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 13597 [details] [review] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity.
Created attachment 13627 [details] [review] [SIGNED-OFF] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 13628 [details] [review] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected'
I wanted to be a on the CC list for this bug, but had to set a patch complexity to do so - update if I was wrong in my assumptions. Nicole
Created attachment 13931 [details] [review] [SIGNED-OFF] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 14668 [details] [review] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 14669 [details] [review] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 14670 [details] [review] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' Amended patch: - add use Modern::Perl; in reports/guided_reports.pl - remove a simple-quote string in guided_reports_start.tt Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Rebased patches.
Hi Jonathan - could you rebase? I started looking into this, but I think better you resolve. Will then test this next.
Created attachment 16241 [details] [review] [SIGNED-OFF] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 16244 [details] [review] [SIGNED-OFF] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 16246 [details] [review] [SIGNED-OFF] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected'
All patches rebased on master.
Found a little something: When limiting to subgroups the limit seems to do a truncated search: STH = Something STHE = Something Else Limiting on STHE worked perfectly, limiting on STH still gives me all reports for STH and STHE. Can be dealt with in a follow-up patch. Continuing testing.
Created attachment 16270 [details] [review] Bug 9117 [Follow-up] Fix group and subgroup filtering When a group code is contained in another group code (e.g. 'COD' and 'CODE'), filtering on the longest ('CODE') include reports of the smallest ('COD'). Same problem for the subgroups. This patch fixes this.
Created attachment 16271 [details] [review] Bug 9117 [Follow-up] Translatable string should be in double quotes
Created attachment 16282 [details] [review] [PASSED QA] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16283 [details] [review] [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16284 [details] [review] [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16285 [details] [review] [PASSED QA] Bug 9117 [Follow-up] Fix group and subgroup filtering When a group code is contained in another group code (e.g. 'COD' and 'CODE'), filtering on the longest ('CODE') include reports of the smallest ('COD'). Same problem for the subgroups. This patch fixes this. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16286 [details] [review] [PASSED QA] Bug 9117 [Follow-up] Translatable string should be in double quotes Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Tests done: - Created several reports fresh and using the new duplicate feature. - Verified authorized values were created correctly and can be viewed from Administration > authorized values. - Checked tabs and limiting on subgroups works correctly.
Created attachment 16287 [details] [review] [PASSED QA] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16288 [details] [review] [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16290 [details] [review] [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16292 [details] [review] [PASSED QA] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16293 [details] [review] [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16294 [details] [review] [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16295 [details] [review] [PASSED QA] Bug 9117 [Follow-up] Fix group and subgroup filtering When a group code is contained in another group code (e.g. 'COD' and 'CODE'), filtering on the longest ('CODE') include reports of the smallest ('COD'). Same problem for the subgroups. This patch fixes this. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 16296 [details] [review] [PASSED QA] Bug 9117 [Follow-up] Translatable string should be in double quotes Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Tests done: - Created several reports fresh and using the new duplicate feature. - Verified authorized values were created correctly and can be viewed from Administration > authorized values. - Checked tabs and limiting on subgroups works correctly.
We need a unit test for C4::Koha::AddAuthorisedValue. Once one is provided, please set this patch back to "Passed QA." As an aside, making all the authorised value adding bits of code use the same AddAuthorisedValue subroutine might be good.
Created attachment 16653 [details] [review] Bug 9117: Add imageurl to the list of parameters of AddAuthorisedValue and add unit test in t/db_dependant/Koha.t
To integrate well with other unit tests, I had to add imageurl parameter to AddAuthorisedValue
(In reply to comment #35) > To integrate well with other unit tests, I had to add imageurl parameter to > AddAuthorisedValue Thanks. I dislike the use of ok() for this sort of test on principle, but as it was already there and the tests pass perfectly with the introduction of the new routine, I am satisfied with this follow-up and will be pushing this.
This patch has been pushed to master.