See the 3.8 manual: http://manual.koha-community.org/3.8/en/additionaltools.html#editevents there were different options depending on the type of event you were editing. In 3.10/master when you edit a unique event you have the option to do things on a range and or generate an exception ... seems silly. There is no range on a unique holiday and there is no exception to generate. We should only have reasonable editing options when editing events.
Still valid.
Created attachment 111214 [details] [review] Bug 9118: Do not show option to create exception on range for unique holiday When an unique holiday is edited one can choose option 'Generate exceptions on a range of dates.' Exceptions are meant to be used with repeating holidays and it makes no sense to have option to be able to create one for an unique holiday. This patch hides exception on range option when editing an unique holiday. Also fixes a minor spelling error. To test: 1. Create unique holiday and edit it. 2. Note that option to create exception on range is shown. 3. Apply patch. => Option is now hidden.
Created attachment 111310 [details] [review] Bug 9118: Do not show option to create exception on range for unique holiday When an unique holiday is edited one can choose option 'Generate exceptions on a range of dates.' Exceptions are meant to be used with repeating holidays and it makes no sense to have option to be able to create one for an unique holiday. This patch hides exception on range option when editing an unique holiday. Also fixes a minor spelling error. To test: 1. Create unique holiday and edit it. 2. Note that option to create exception on range is shown. 3. Apply patch. => Option is now hidden. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 111558 [details] [review] Bug 9118: Do not show option to create exception on range for unique holiday When an unique holiday is edited one can choose option 'Generate exceptions on a range of dates.' Exceptions are meant to be used with repeating holidays and it makes no sense to have option to be able to create one for an unique holiday. This patch hides exception on range option when editing an unique holiday. Also fixes a minor spelling error. To test: 1. Create unique holiday and edit it. 2. Note that option to create exception on range is shown. 3. Apply patch. => Option is now hidden. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 111559 [details] [review] Bug 9118: (QA follow-up) Fix spelling on "To Date :" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
I really love these kind of small usability fixes.
Pushed to master for 20.11, thanks to everybody involved!
enhancement, not backported to 19.11.x
Lucas has also backported this to 20.05.x for 20.05.06