Bug 9132 - Paging through OPAC authority search results does not work
Summary: Paging through OPAC authority search results does not work
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Fridolin Somers
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-22 11:02 UTC by Marcel de Rooy
Modified: 2013-05-23 06:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (main) (1.02 KB, patch)
2012-11-23 11:17 UTC, Fridolin Somers
Details | Diff | Splinter Review
Proposed patch (follow-up 1) (2.16 KB, patch)
2012-11-23 11:18 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 9132: Paging through OPAC authority search results does not work (1.08 KB, patch)
2012-11-23 13:18 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 9132: Paging through OPAC authority search results does not work (followup 1) input with and_ora instread of and_or (2.21 KB, patch)
2012-11-23 13:18 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9132: Paging through OPAC authority search results does not work (1.21 KB, patch)
2012-11-27 07:35 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9132: Paging through OPAC authority search results does not work (followup 1) input with and_ora instread of and_or (2.28 KB, patch)
2012-11-27 07:35 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2012-11-22 11:02:43 UTC
Search for a term with more than 20 hits.
Click page 2.
Note that you go to the second page of search results of any=*

Somehow the searchdata template var is not filled correctly, making the links for other pages not working.
Comment 1 Marcel de Rooy 2012-11-22 11:23:23 UTC
Just wondering if this is the case under 3.10.0 also?
Comment 2 Fridolin Somers 2012-11-23 11:17:09 UTC Comment hidden (obsolete)
Comment 3 Fridolin Somers 2012-11-23 11:18:30 UTC Comment hidden (obsolete)
Comment 4 Jared Camins-Esakov 2012-11-23 13:18:38 UTC Comment hidden (obsolete)
Comment 5 Jared Camins-Esakov 2012-11-23 13:18:47 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2012-11-25 17:44:13 UTC
I can't seem to reproduce the problem on current master. Can I get a more detailed test plan?

I tried a search for contains 'Müller' and got 4 pages with results. I paged back and forward using the numbered links and arrows but didn't notice problems.
Comment 7 Marcel de Rooy 2012-11-26 10:05:50 UTC
(In reply to comment #6)
> I can't seem to reproduce the problem on current master. Can I get a more
> detailed test plan?
> 
> I tried a search for contains 'Müller' and got 4 pages with results. I paged
> back and forward using the numbered links and arrows but didn't notice
> problems.

I still can. Try this in OPAC?
Go to Browse for author and subject.
Look for: a
Note the (larger) number of hits.
Click on page 2.
Check the number of hits again.
In my case it is now even higher. I have all results.
Comment 8 Katrin Fischer 2012-11-26 10:07:26 UTC
Hi Marcel,

thx for the hints! I was checking the staff interface - will go back and check the OPAC search.
Comment 9 Katrin Fischer 2012-11-27 07:35:22 UTC
Created attachment 13701 [details] [review]
[SIGNED-OFF] Bug 9132: Paging through OPAC authority search results does not work

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixes paging in authority result list in OPAC.
All tests pass.
Comment 10 Katrin Fischer 2012-11-27 07:35:31 UTC
Created attachment 13702 [details] [review]
[SIGNED-OFF] Bug 9132: Paging through OPAC authority search results does not work (followup 1) input with and_ora instread of and_or

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 11 Katrin Fischer 2012-11-27 07:37:08 UTC
Sorry for the status confusion - seems git bz changed the status back to 'Signed Off' when I attached the second patch. Something to investigate later.
Comment 12 Jared Camins-Esakov 2012-11-28 13:26:00 UTC
This patch has been pushed to master.
Comment 13 Chris Cormack 2012-11-29 02:30:53 UTC
Pushed to 3.10.x will be in 3.10.1