Now all notes (3XX on UNIMARC and 5XX on MARC21) appears on the title notes separator (OPAC) and description separator (Staff Client). The fields that appear in that separators should be controlled by a system preference. Example: Cataloguing separator - Display section NotesBlacklist - Don't show these [list of fields separated with comma] note fields in title notes separator (OPAC record details) and in the description separator (Staff client record details). The fields should appear separated with commas and according with the Koha MARC format (eg 3.. for UNIMARC, 5.. for MARC21)
Created attachment 13730 [details] [review] BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator Added a new system preference to control the fields to not appear in the separator. Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list,
Vitor, for future reference you are not allowed to use tab characters in Koha code. In particular, the system preferences files are broken by tabs.
Created attachment 13916 [details] [review] BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator Added a new system preference to control the fields to not appear in the separator. Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list,
My blacklisted fields still display on the record details in the OPAC and Intranet. Please provide a test plan, I may be testing this incorrectly.
One other QA comment, please don't just use 'XXX' for DB revisions. updatedatabase.pl doesn't like that, please use the format '3.11.00.XXX'.
Hi Kyle, Sorry for the tab and XXX version problems. These are my first patches so it's normal to have some errors. I'll try to avoid those in the future. Problem: - All notes fields are shown in the 'title notes' separator on OPAC record details - All notes fields are shown in the 'description' separator on intranet record details Test plan: - Search for a record that has a note field (3XX in UNIMARC or 5XX in MARC21) - Check if that note appears in the separator 'title notes' of OPAC record details - Add the note field tag in the created system preference - Refresh the record detail page and check if the note stills appears - Check if that note appears in the separator 'description' of intranet record details - Add the note field tag in the created system preference - Refresh the record detail page and check if the note stills appears
Created attachment 14121 [details] [review] [SIGNED-OFF] BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator Added a new system preference to control the fields to not appear in the separator. Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list, Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Works as advertised. Thanks for the test plan!
QA Comments: The proposed patch works well. However if all existing fields are blacklisted, the biblio.notes field is displayed. So if you blacklist the 300$a and if it is mapped with this db field, it will be displayed. Possible improvement : Perhaps some libraries would like to blacklist some fields for the opac and fewer fields for the intranet (required 1 syspref by interface). Marked as Passed QA.
Created attachment 14264 [details] [review] BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator Added a new system preference to control the fields to not appear in the separator. Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list, Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> FIX some indentation in C4/Biblio.pm
Created attachment 14265 [details] [review] BUG 9162 - Add a system preference to set which notes fields appears on title notes/description separator Added a new system preference to control the fields to not appear in the separator. Change GetMarcNotes to use the system preference created to only appear the fields that aren't in the list, Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> FIX some indentation in C4/Biblio.pm +FIX 1 end of parentheses in sysprefs.sql
This patch has been pushed to master.