Bug 9203 - limit pull down broken when adding biblio to subscription
Summary: limit pull down broken when adding biblio to subscription
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-04 00:24 UTC by Nicole C. Engard
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
how it used to be (47.47 KB, image/png)
2012-12-04 00:24 UTC, Nicole C. Engard
Details
pull down now (84.57 KB, image/jpeg)
2012-12-04 00:25 UTC, Nicole C. Engard
Details
Bug 9203 [Incomplete] limit pull down broken when adding biblio to subscription (6.47 KB, patch)
2013-05-10 15:11 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2012-12-04 00:24:32 UTC
Created attachment 13864 [details]
how it used to be

when you click search for biblio when adding a new subscription you see a search box and a limiter - but the limiter only has 'All' - it used to have item types in it.
Comment 1 Nicole C. Engard 2012-12-04 00:25:05 UTC
Created attachment 13865 [details]
pull down now
Comment 2 Owen Leonard 2013-05-10 14:09:15 UTC
The script seems to have been modified to check the AdvancedSearchTypes system preference and display options based on that (ccode,itemtype, or loc). However, it only works if you have a single choice. If you have "itemtypes|ccode" in your preference it breaks.
Comment 3 Owen Leonard 2013-05-10 15:11:21 UTC
Created attachment 18072 [details] [review]
Bug 9203 [Incomplete] limit pull down broken when adding biblio to subscription

When creating a subscription, if you use "Search for Biblio" link to
search for an existing record the popup has a broken item type selection
option. This broke when it became possible to add multiple values to
the AdvancedSearchTypes system preference.

This patch uses code from opac-search.pl as a template for enabling
handling of multiple search limiters when buliding the search form.

HOWEVER, I'm not sure how to amend the search process to handle multiple
limiters. I would be grateful if someone could take it over from here or
walk me through the process.
Comment 4 Katrin Fischer 2014-03-26 23:19:13 UTC
The form now always offers itemtype and collection code searching in separate pull downs - closing as fixed.