Created attachment 13864 [details] how it used to be when you click search for biblio when adding a new subscription you see a search box and a limiter - but the limiter only has 'All' - it used to have item types in it.
Created attachment 13865 [details] pull down now
The script seems to have been modified to check the AdvancedSearchTypes system preference and display options based on that (ccode,itemtype, or loc). However, it only works if you have a single choice. If you have "itemtypes|ccode" in your preference it breaks.
Created attachment 18072 [details] [review] Bug 9203 [Incomplete] limit pull down broken when adding biblio to subscription When creating a subscription, if you use "Search for Biblio" link to search for an existing record the popup has a broken item type selection option. This broke when it became possible to add multiple values to the AdvancedSearchTypes system preference. This patch uses code from opac-search.pl as a template for enabling handling of multiple search limiters when buliding the search form. HOWEVER, I'm not sure how to amend the search process to handle multiple limiters. I would be grateful if someone could take it over from here or walk me through the process.
The form now always offers itemtype and collection code searching in separate pull downs - closing as fixed.