The idea is to check if the patron have any document of the record that he is trying to place hold. This verification will be done almost ate the same time than if book can be reserved and item can be reserved by the patron. There will be a system preference to turn on/off this verification (AllowHoldsOnPatronsPossessions or something like that).
Created attachment 13881 [details] [review] BUG 9206 - Only allow place holds in records that the patron don't have in his possession Added a system preference to turn on/off this feature. By default the system allow the patron to place holds even if it is in his possession. Script to place holds check if the system preference is off and if patron has at least one item to block holds. Messages to say that are already in patron possession added to templates. Method to check if patron has one issue from one record added to C4::Circulation
Created attachment 14126 [details] [review] [SIGNED-OFF] Bug 9206 - Only allow place holds in records that the patron don't have in his possession Added a system preference to turn on/off this feature. By default the system allow the patron to place holds even if it is in his possession. Script to place holds check if the system preference is off and if patron has at least one item to block holds. Messages to say that are already in patron possession added to templates. Method to check if patron has one issue from one record added to C4::Circulation Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 14127 [details] [review] Bug 9206 - Only allow place holds in records that the patron don't have in his possession - QA Followup
My followup fixes up some minor syntax errors and wording. If anyone feels these changes justify a second SO please reset the status.
QA Comments: Looks good to me. I tested the feature (on/off) at the opac and the intranet, I didn't find any issue. I will submit a followup (fix indentation and the return of the new routine CheckIfIssuedToPatron). Jared, could you switch back the status to Needs signoff if you require one for it? Marked as Passed QA.
Created attachment 14266 [details] [review] Bug 9206 - Only allow place holds in records that the patron don't have in his possession Added a system preference to turn on/off this feature. By default the system allow the patron to place holds even if it is in his possession. Script to place holds check if the system preference is off and if patron has at least one item to block holds. Messages to say that are already in patron possession added to templates. Method to check if patron has one issue from one record added to C4::Circulation Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 14267 [details] [review] Bug 9206 - Only allow place holds in records that the patron don't have in his possession - QA Followup Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 14268 [details] [review] Bug 9206: Followup QA FIX - Fix indentation - It is useless to loop on all items. If at least 1 item is already issued, we want to return 1.
This patch has been pushed to master.
*** Bug 3551 has been marked as a duplicate of this bug. ***
*** Bug 9702 has been marked as a duplicate of this bug. ***