When a reference item has a 'not for loan' status as well as a 'damaged' status the opac only displays the 'not for loan'. This can be an issue with reference material because if it is damaged it is not accessible where as if it is 'not for loan' it is accessible. Can this situation display in the opac as it does in the staff client and show both statues? Ed
I'd love to see some work on this. For any library with damaged reference books or periodical titles that are non-circulating, this causes some serious confusion for patrons. Thanks! Amber Hunt Marlboro College Marlboro, VT
Created attachment 32047 [details] [review] Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file.
Created attachment 32048 [details] [review] Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan This patch contains the compiled opac.css file generated from the revised LESS file in this bug's other patch.
Patch tested with a sandbox, by amber@marlboro.edu <1>
Created attachment 32049 [details] [review] Bug 12937: Deleting suggestions should ask for a confirmation On the suggestion management page, the librarian can choose to delete suggestions but no confirmation is needed. This could produce unexpected lost of data. Test plan: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: amber@marlboro.edu <1>
Created attachment 32050 [details] [review] Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation This minor follow-up revises the language a bit: Adding missing question marks and using the more standard prompt "Please select at least one..." To test, follow the previous test plan and confirm that the prompts are improved: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: amber@marlboro.edu <1>
Well, I tried to be helpful and test the patch, but have apparently done something wrong resulting in the last three posts. Sorry about that. I'll bow out on this one, but THANKS OWEN for starting work on this.
Created attachment 32160 [details] [review] Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 32161 [details] [review] Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan This patch contains the compiled opac.css file generated from the revised LESS file in this bug's other patch. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 32269 [details] [review] Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 32270 [details] [review] Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan This patch contains the compiled opac.css file generated from the revised LESS file in this bug's other patch. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 33463 [details] [review] Bug 9214 - Show damaged status in the OPAC for items which are not for loan Item statuses in the OPAC displayed according to a cascading hierarchy: If something is lost it will appear as lost, "else if" it is checked out it will appear as checked out, etc. I don't think there is a logical reason why statuses should appear this way. This patch modifies the logic in the template so that multiple statuses can be displayed at the same time. The patch also wraps each status in its own class so that libraries can apply custom CSS if they wish. Some tweaks have been made to the LESS file adding some style to the common "item-status" class for display of item statuses. To test, apply the patch and view one or more titles in the OPAC which have items with the following statuses: lost, checked out, damaged, not for loan, waiting, on order, in transit, withdrawn, and available. Modify items to have more that one status simultaneously, in particular not for loan and damaged. Also test the display of item statuses in the OPAC cart and the OPAC's course details page (Course reserves -> [Course name]) since these pages use the same include file. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 33464 [details] [review] Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan This patch contains the compiled opac.css file generated from the revised LESS file in this bug's other patch. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Owen!