Bug 9214 - Show damaged status in the OPAC for items which are not for loan
Summary: Show damaged status in the OPAC for items which are not for loan
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-04 21:41 UTC by Ed Veal
Modified: 2015-06-04 23:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9214 - Show damaged status in the OPAC for items which are not for loan (7.47 KB, patch)
2014-10-07 18:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan (84.31 KB, patch)
2014-10-07 18:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 12937: Deleting suggestions should ask for a confirmation (3.28 KB, patch)
2014-10-07 19:30 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation (2.56 KB, patch)
2014-10-07 19:31 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 9214 - Show damaged status in the OPAC for items which are not for loan (7.48 KB, patch)
2014-10-10 14:52 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan (84.32 KB, patch)
2014-10-10 14:53 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 9214 - Show damaged status in the OPAC for items which are not for loan (7.54 KB, patch)
2014-10-11 20:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan (84.38 KB, patch)
2014-10-11 20:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 9214 - Show damaged status in the OPAC for items which are not for loan (8.30 KB, patch)
2014-11-11 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan (84.57 KB, patch)
2014-11-11 17:52 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Veal 2012-12-04 21:41:29 UTC
When a reference item has a 'not for loan' status as well as a 'damaged' status the opac only displays the 'not for loan'. This can be an issue with reference material because if it is damaged it is not accessible where as if it is 'not for loan' it is accessible. 

Can this situation display in the opac as it does in the staff client and show both statues?

Ed
Comment 1 Amber Hunt 2014-10-07 16:02:52 UTC
I'd love to see some work on this. For any library with damaged reference books or periodical titles that are non-circulating, this causes some serious confusion for patrons.

Thanks!
Amber Hunt
Marlboro College
Marlboro, VT
Comment 2 Owen Leonard 2014-10-07 18:37:19 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2014-10-07 18:38:00 UTC Comment hidden (obsolete)
Comment 4 Biblibre Sandboxes 2014-10-07 19:30:13 UTC
Patch tested with a sandbox, by amber@marlboro.edu <1>
Comment 5 Biblibre Sandboxes 2014-10-07 19:30:59 UTC Comment hidden (obsolete)
Comment 6 Biblibre Sandboxes 2014-10-07 19:31:02 UTC Comment hidden (obsolete)
Comment 7 Amber Hunt 2014-10-07 19:35:20 UTC
Well, I tried to be helpful and test the patch, but have apparently done something wrong resulting in the last three posts. Sorry about that. I'll bow out on this one, but THANKS OWEN for starting work on this.
Comment 8 Chris Cormack 2014-10-10 14:52:13 UTC Comment hidden (obsolete)
Comment 9 Chris Cormack 2014-10-10 14:53:15 UTC Comment hidden (obsolete)
Comment 10 Katrin Fischer 2014-10-11 20:02:38 UTC Comment hidden (obsolete)
Comment 11 Katrin Fischer 2014-10-11 20:02:55 UTC Comment hidden (obsolete)
Comment 12 Owen Leonard 2014-11-11 17:52:46 UTC
Created attachment 33463 [details] [review]
Bug 9214 - Show damaged status in the OPAC for items which are not for loan

Item statuses in the OPAC displayed according to a cascading hierarchy:
If something is lost it will appear as lost, "else if" it is checked out
it will appear as checked out, etc. I don't think there is a logical
reason why statuses should appear this way.

This patch modifies the logic in the template so that multiple statuses
can be displayed at the same time. The patch also wraps each status in
its own class so that libraries can apply custom CSS if they wish.

Some tweaks have been made to the LESS file adding some style to the
common "item-status" class for display of item statuses.

To test, apply the patch and view one or more titles in the OPAC which
have items with the following statuses: lost, checked out, damaged, not
for loan, waiting, on order, in transit, withdrawn, and available.

Modify items to have more that one status simultaneously, in particular
not for loan and damaged.

Also test the display of item statuses in the OPAC cart and the OPAC's
course details page (Course reserves -> [Course name]) since these pages
use the same include file.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 13 Owen Leonard 2014-11-11 17:52:52 UTC
Created attachment 33464 [details] [review]
Bug 9214 [Compiled CSS] Show damaged status in the OPAC for items which are not for loan

This patch contains the compiled opac.css file generated from the
revised LESS file in this bug's other patch.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 14 Tomás Cohen Arazi 2014-11-11 18:27:47 UTC
Patches pushed to master.

Thanks Owen!