Bug 9222 - manual history reversed in subscription-detail.pl
Summary: manual history reversed in subscription-detail.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-06 09:04 UTC by Fridolin Somers
Modified: 2014-02-26 07:00 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed patch (1.11 KB, patch)
2012-12-06 09:05 UTC, Fridolin Somers 		Details | Diff | Splinter Review
Bug 9222: manual history reversed in subscription-detail.pl (1.16 KB, patch)
2012-12-14 15:53 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Bug 9222: manual history reversed in subscription-detail.pl (1.26 KB, patch)
2013-02-08 10:26 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2012-12-06 09:04:11 UTC 
Edit a subscription and check manual history : in subscription-detail.pl, manual history shows "disabled".
Edit a subscription and uncheck manual history : in subscription-detail.pl, manual history shows "enabled".
Manual history is reversed in subscription-detail.tt.
Comment 1 Fridolin Somers 2012-12-06 09:05:56 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall (khall) 2012-12-14 15:53:24 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-02-08 10:26:38 UTC 
Created attachment 15156 [details] [review]
Bug 9222: manual history reversed in subscription-detail.pl

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2013-02-08 10:27:26 UTC 
QA Comment:
Trivial patch. Works as advertised.

Passed QA
Comment 5 Jared Camins-Esakov 2013-02-08 14:11:13 UTC 
Fridolyn, in the future please be sure to include commit messages, following the guidelines at http://wiki.koha-community.org/wiki/Commit_messages
Comment 6 Fridolin Somers 2013-02-08 14:19:26 UTC 
(In reply to comment #5)
> Fridolyn, in the future please be sure to include commit messages, following
> the guidelines at http://wiki.koha-community.org/wiki/Commit_messages

Yes, I'm aware of it. This patch must have been made before I knew about it.

Best regards.
Comment 7 Jared Camins-Esakov 2013-02-10 18:16:21 UTC 
This patch has been pushed to master.
Comment 8 Chris Cormack 2013-02-14 08:45:56 UTC 
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.9