Bug 9226 - Wrong branch filter after suggestion creation
Summary: Wrong branch filter after suggestion creation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-06 14:11 UTC by Fridolin Somers
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.81 KB, patch)
2012-12-06 14:14 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9226: Wrong branch filter after suggestion creation (2.13 KB, patch)
2012-12-26 16:48 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9226: Wrong branch filter after suggestion creation (2.15 KB, patch)
2013-02-15 10:04 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2012-12-06 14:11:03 UTC
In suggestions management :
When suggestions are not filtered on a branch, they are filtered on your branch (the branch of connected user).
But when you create a new suggestion for another branch, after saving you come back to suggestions list and there they are filtered on the other branch instead of your branch.
Comment 1 Fridolin Somers 2012-12-06 14:14:34 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-12-26 16:48:16 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-02-15 09:38:16 UTC
QA: Looking at this one now.
Comment 4 Marcel de Rooy 2013-02-15 10:04:01 UTC
Created attachment 15336 [details] [review]
Bug 9226: Wrong branch filter after suggestion creation

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Before the patch, upon submitting a new suggestion in the staff client I
was redirected to a view which was not filtered by branch. After the
patch I was redirected to a view which was filtered by my logged-in
branch.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2013-02-15 10:05:03 UTC
QA Comment:
Looks good to me. The patch makes a small improvement.
This is outside the scope of your report: But if I clear the filter, I am still surprised that it filters by my branch. 
Clear actually means here something as Default. Two links: Clear and Default would be even more nice :)
Organize by-combo should also keep its value and not go back to Status when the display is e.g. Library.

Passed QA
Comment 6 Jared Camins-Esakov 2013-02-15 13:34:27 UTC
This patch has been pushed to master.
Comment 7 Chris Cormack 2013-02-16 05:38:09 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10