Bug 9229 - branch code instead of name in subscription-detail.pl
Summary: branch code instead of name in subscription-detail.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-06 15:33 UTC by Fridolin Somers
Modified: 2014-05-26 21:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.46 KB, patch)
2012-12-06 15:50 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 9229: branch code instead of name in subscription-detail.pl (2.51 KB, patch)
2012-12-14 16:06 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9229 - branch code instead of name in subscription-detail.pl - Using KohaBranchName plugin (1.74 KB, patch)
2012-12-14 16:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9229 - branch code instead of name in subscription-detail.pl - Using KohaBranchName plugin (1.81 KB, patch)
2012-12-17 13:52 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 9229 - branch code instead of name in subscription-detail.pl - Using KohaBranchName plugin (2.00 KB, patch)
2013-01-17 15:00 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2012-12-06 15:33:04 UTC
In subscription-detail.pl, the branch code is displayed instead of the branch name.
Comment 1 Fridolin Somers 2012-12-06 15:50:11 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-12-14 16:06:11 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2012-12-14 16:09:30 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2012-12-14 16:12:16 UTC
Here is also an alternative version using the KohaBranchName plugin. I think it may be a bit better to do with this way, keeping our view and controller more separated ( plus it seems simpler as well ). It's the original author's and the QA teams call though.
Comment 5 Fridolin Somers 2012-12-17 13:52:40 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-01-17 15:00:36 UTC
QA comment:
Simple patch, works as expected.
Marked as Passed QA.
Comment 7 Jonathan Druart 2013-01-17 15:00:56 UTC
Created attachment 14674 [details] [review]
Bug 9229 - branch code instead of name in subscription-detail.pl - Using KohaBranchName plugin

Test plan:
Go in a subscription detail page.
Check that the "Library" information is changed from the branchcode to
the branchname

Signed-off-by: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jared Camins-Esakov 2013-01-18 02:02:17 UTC
This patch has been pushed to master.
Comment 9 Chris Cormack 2013-01-24 02:21:23 UTC
Pushed to 3.10.x and 3.8.x, will be in 3.10.3 and 3.8.10