Bug 9235 - Hardcoded values in cronjobs/backup.sh
Summary: Hardcoded values in cronjobs/backup.sh
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Galen Charlton
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-06 19:44 UTC by Tomás Cohen Arazi
Modified: 2013-05-23 06:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9235 - Hardcoded values in cronjobs/backup.sh (2.16 KB, patch)
2012-12-06 19:57 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9235 - Hardcoded values in cronjobs/backup.sh (2.21 KB, patch)
2012-12-07 14:06 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9235 - Hardcoded values in cronjobs/backup.sh (2.28 KB, patch)
2012-12-21 11:35 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2012-12-06 19:44:53 UTC
There are several hardcoded values that should be read from config files.
Comment 1 Tomás Cohen Arazi 2012-12-06 19:57:27 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-12-07 14:06:00 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2012-12-21 11:34:37 UTC
QA Comments:

Now the backup script gets information from the $KOHA_CONF file.

Marked as Passed QA.
Comment 4 Jonathan Druart 2012-12-21 11:35:17 UTC
Created attachment 14221 [details] [review]
Bug 9235 - Hardcoded values in cronjobs/backup.sh

This patch makes the script read those parameters from the corresponding
$KOHA_CONF file.

Regards
To+

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jared Camins-Esakov 2012-12-21 12:21:23 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2012-12-21 19:30:59 UTC
Pushed to 3.10.x, will be in 3.10.1