Bug 9244 - Authorities sorting should take subdivisions into account thanks to DOM
Summary: Authorities sorting should take subdivisions into account thanks to DOM
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-07 14:38 UTC by Gaetan Boisson
Modified: 2022-12-12 21:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gaetan Boisson 2012-12-07 14:38:49 UTC
When searching amongst authorities, results area sorted alphabetically on the heading, but sudvisions are not taken into account, leading to confusing results lists for headings with a lot of subdivisions.

This should be easily feasible with DOM.
Comment 1 laurenthdl 2012-12-07 16:12:22 UTC
C4/AuthoritiesMarc.pm
change line 292 into

         $orderstring = '@and @attr 7=1 @attr 1=Heading-Main 0 @attr 7=1 @attr 1=Heading 1';

That should do the job.
Comment 2 Katrin Fischer 2019-04-28 09:20:26 UTC
Neither hdl nor Gaetan are around any longer. But maybe someone else could confirm this bug on a UNIMARC setup and add a step by step to reproduce? (not sure how to catalog this in UNIMARC or MARC21)
Comment 3 Heather 2022-02-07 17:44:53 UTC
We're on 21.05 with MARC21 and authorities are now sorting *with* subdivisions being taken into account, e.g. the following where a subdivision is indicated by a capital letter in the word following the word "Ships" (without capitalization indicates a phrase heading):

Topical Term:
Ships Heating and ventilation
used for/see from:
Ships Ventilation
see also:
Marine machinery (Broader heading)
Topical Term	3 record(s)
	
Topical Term:
Ships Hydraulic equipment
see also:
Hydraulic machinery (Broader heading)
Topical Term	1 record(s)	

Topical Term:
Ships Hydrodynamics
used for/see from:
Ships Dynamics
see also:
Hydrodynamics (Broader heading)
Naval architecture (Broader heading)
Stability of ships
Topical Term	7 record(s)	

Topical Term:
Ships in art
Topical Term	101 record(s)	

Topical Term:
Ships in literature
Topical Term	2 record(s)	

Topical Term:
Ships in motion pictures
see also:
Motion pictures (Broader heading)
Topical Term	8 record(s)	

Topical Term:
Ships in numismatics
used for/see from:
Ships on coins
see also:
Numismatics (Broader heading)
Topical Term	5 record(s)	

Topical Term:
Ships Inspection
used for/see from:
Marine surveying
Ship inspection
Steamboats Inspection
see also:
Maritime law (Broader heading)
Topical Term	33 record(s)	

Topical Term:
Ships Inspection United States
Topical Term	20 record(s)	

Topical Term:
Ships Launching
used for/see from:
Launching of ships
see also:
Shipyards (Broader heading)
Topical Term	26 record(s)	

Topical Term:
Ships Maintenance and repair
used for/see from:
Merchant ships Maintenance and repair
Ship maintenance
Ship repairing
Ships Repairing
see also:
Damage control (Warships)
Shipbuilding (Broader heading)
Topical Term	57 record(s)	

Topical Term:
Ships Maneuverability
used for/see from:
Maneuverability of ships
see also:
Ship handling (Broader heading)
Ships Hydrodynamics (Broader heading)
Topical Term	6 record(s)	

Topical Term:
Ships Manning
used for/see from:
Manning of vessels
Topical Term	10 record(s)	

Topical Term:
Ships Measurement
Topical Term	13 record(s)	

Topical Term:
Ships of the line
used for/see from:
Warships, Sail
see also:
Sailing ships (Broader heading)
Warships (Broader heading)
Topical Term	20 record(s)	

Topical Term:
Ships on postage stamps
see also:
Postage stamps (Broader heading)
Topical Term	15 record(s)	

Topical Term:
Ships Painting
see also:
Painting, Industrial (Broader heading)
Topical Term	9 record(s)	

Topical Term:
Ships Passenger lists
used for/see from:
Passenger lists
see also:
Lists (Broader heading)
Topical Term	21 record(s)	

Topical Term:
Ships Preservation
used for/see from:
Mothballing of ships
Topical Term	2 record(s)	

Topical Term:
Ships Ratproof construction
see also:
Ratproof construction (Broader heading)

It's also working in the OPAC:
https://keys.bywatersolutions.com/cgi-bin/koha/opac-authorities-home.pl?marclist=mainentry&and_or=and&excluding=&operator=start&value=ships&resultsperpage=20&type=opac&op=do_search&authtypecode=TOPIC_TERM&orderby=HeadingAsc&startfrom=2

So this seems to have been fixed during one of the upgrades.  Woo-hoo!!

Cheerio!
h2
Comment 4 Katrin Fischer 2022-02-07 21:14:29 UTC
Hi Heather, are you using Zebra or Elasticserach?
Comment 5 Heather 2022-02-07 21:37:40 UTC
Hi, Katrin!

Silly me--I forgot to mention that we're on Elasticsearch.

Thank you for reminding me--sorry for forgetting it!
--h2
Comment 6 Katrin Fischer 2022-02-07 21:39:15 UTC
Hi Heather, no problem at all, I seemed to remember, but was not sure either. Was wondering if we should close this, but maybe we should wait for someone to confirm behaviur for Zebra first.
Comment 7 Heather 2022-02-07 21:57:15 UTC
Hey, Katrin--

I just logged into the Bywater demo, and I didn't see any mention of Elasticsearch in the "About" screen, so I think their demo is on Zebra.  I did several searches in the authority file (staff client & OPAC), and the authority records all sorted correctly.

This is the demo's About page--on our catalog running Elasticsearch, the Elasticsearch line appears just above the Memcached line, which is missing here:
--MySQL version:	mysql Ver 15.1 Distrib 10.1.48-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
--Apache version:	Server version: Apache/2.4.25 (Debian)
--PSGI:	Plack (deployment)
--Memcached:	Servers: 127.0.0.1:11211 | Namespace: koha_demo | Status: running. | Config read from: koha-conf.xml
--Zebra version:	Zebra 2.0.59 (C) 1994-2014, Index Data Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: c00bfddbf0f3608340d61298acc61dafb167f9b2 Using ICU
--Zebra status:	Running

So if this really was a test under Zebra, then I think it's also fixed under Zebra.

Cheerio!
h2
Comment 8 Katrin Fischer 2022-02-07 22:14:53 UTC
Thx Heather, super helpful!
Comment 9 Heather 2022-02-07 22:21:54 UTC
So glad I could help in some small way, Katrin!  And so satisfying to have something from 2012 taken care of, especially something SO helpful to we catalogers!!  ::happy dance::
Comment 10 Katrin Fischer 2022-02-07 22:25:32 UTC
Closing one of the 4 digit bugs is always a treat for sure!