Created attachment 13947 [details] Fine Tab Fines tab showing active I found that if you are on the Fines "Account" tab, the Fines tab on the side of the display shows active, but if you are on the Pay Fines tab, Manual Invoice tab, or Create Manual Credit tabs, the Fines tab on the side no longer shows active. I think this is a visual bug. It should show active no matter what fines tab you are in.
Created attachment 13948 [details] Fines tab
This is still an issue in master.
Created attachment 28862 [details] [review] 9245 Fixes visual bux with fines tab not highlighting This patch makes shure that mancredit.pl, maninvoice.pl and pay.pl passes the value "finesview=1" that makes the tab active. Test plan: 1) Go to a library user and the fines tab. Note that the "Fines" tab loses it's highlight when you click "Pay fines", "Create manual invoice" and "Create manual credit". 2) Install the patch. 3) Redo the first step and make shure that the left menu tab "Fines" is now highlighted all the time.
Created attachment 28874 [details] [review] [SIGNED-OFF] 9245 Fixes visual bux with fines tab not highlighting This patch makes shure that mancredit.pl, maninvoice.pl and pay.pl passes the value "finesview=1" that makes the tab active. Test plan: 1) Go to a library user and the fines tab. Note that the "Fines" tab loses it's highlight when you click "Pay fines", "Create manual invoice" and "Create manual credit". 2) Install the patch. 3) Redo the first step and make shure that the left menu tab "Fines" is now highlighted all the time. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Viktor, looks like we have the same issue we had on bug 12332. Please start the commit message of your patches by "Bug XXXXX". Otherwise the sandboxes cannot signoff them. Thanks. Christopher
(In reply to Christopher Brannon from comment #5) > Viktor, > looks like we have the same issue we had on bug 12332. Please start the > commit message of your patches by "Bug XXXXX". Otherwise the sandboxes > cannot signoff them. Thanks. > > Christopher Yes I missed formatting the first line with "Bug XXXX" in my first five patches. Would I mess up anything if I resubmit those that are not yet signed off with a correct first line?
Created attachment 28981 [details] [review] 9245 Fixes visual bux with fines tab not highlighting This patch makes shure that mancredit.pl, maninvoice.pl and pay.pl passes the value "finesview=1" that makes the tab active. Test plan: 1) Go to a library user and the fines tab. Note that the "Fines" tab loses it's highlight when you click "Pay fines", "Create manual invoice" and "Create manual credit". 2) Install the patch. 3) Redo the first step and make shure that the left menu tab "Fines" is now highlighted all the time. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I developed exactly the same fix yesterday on bug 12447.
*** Bug 12447 has been marked as a duplicate of this bug. ***
Patch pushed to master. Thanks Viktor!
Pushed to 3.16.x for inclusion in 3.16.2.