Bug 9260 - koha-run-backups complains "[: 97: missing ]"
Summary: koha-run-backups complains "[: 97: missing ]"
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-11 14:14 UTC by MJ Ray (software.coop)
Modified: 2013-05-23 06:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9260: stop koha-run-backups complaining "missing ]" (1.15 KB, patch)
2012-12-11 14:28 UTC, MJ Ray (software.coop)
Details | Diff | Splinter Review
Bug 9019: Return item fields in ILS-DI GetRecords (1.42 KB, patch)
2012-12-11 15:16 UTC, Vitor Fernandes
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9260: stop koha-run-backups complaining "missing ]" (1.21 KB, patch)
2012-12-11 15:44 UTC, Vitor Fernandes
Details | Diff | Splinter Review
Bug 9260: stop koha-run-backups complaining "missing ]" (1.38 KB, patch)
2012-12-21 13:05 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description MJ Ray (software.coop) 2012-12-11 14:14:31 UTC
The cron.daily for 3.10 packages produces the following error mailed to root:

[: 97: missing ]
[: 97: missing ]
[: 97: missing ]

I've isolated this to koha-run-backups --days 2 --output /var/spool/koha

Patch will follow in a few seconds.
Comment 1 MJ Ray (software.coop) 2012-12-11 14:28:10 UTC Comment hidden (obsolete)
Comment 2 Vitor Fernandes 2012-12-11 15:16:41 UTC Comment hidden (obsolete)
Comment 3 Vitor Fernandes 2012-12-11 15:44:32 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2012-12-21 13:05:15 UTC
QA Comments:

This patch fixes a syntax error in a sh script.

Marked as Passed QA.
Comment 5 Jonathan Druart 2012-12-21 13:05:35 UTC
Created attachment 14222 [details] [review]
Bug 9260: stop koha-run-backups complaining "missing ]"

Found because cron.daily/koha output contains the error "[: 97: missing ]"

To test:

  1. run koha-run-backups --days 2 --output /var/spool/koha
  2. should see no output

Sponsored-by: Library of the Józef Piłsudski Institute of America
Signed-off-by: Vitor FERNANDES <vfernandes@keep.pt>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I still get an error:
  ./koha-run-backups: 58: ./koha-run-backups: koha-list: not found
But this patch fixes the syntax error
Comment 6 Jared Camins-Esakov 2012-12-21 13:12:01 UTC
This patch has been pushed to master.
Comment 7 Chris Cormack 2012-12-21 19:37:39 UTC
Pushed to 3.10.x will be in 3.10.1