Bug 9263 - Trim barcodes in offline circulation
Summary: Trim barcodes in offline circulation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Fridolin Somers
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-11 16:32 UTC by Fridolin Somers
Modified: 2014-05-26 21:04 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.36 KB, patch)
2012-12-11 16:35 UTC, Fridolin Somers
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9263: Trim barcodes in offline circulation (2.41 KB, patch)
2012-12-12 15:40 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9263 - Followup - Improve speed of substitution. (1.33 KB, patch)
2012-12-12 15:42 UTC, Kyle M Hall
Details | Diff | Splinter Review
Proposed patch (revisited) (2.43 KB, patch)
2012-12-12 16:20 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 9263: Trim barcodes in offline circulation (2.48 KB, patch)
2012-12-12 17:24 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2012-12-11 16:32:19 UTC
In normal circulation page, when a barcode starts or ends with spaces, they are ignored and circulation is performed.
Do the same in barcodes coming form offline circulation.
Comment 1 Fridolin Somers 2012-12-11 16:35:00 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-12-12 15:40:41 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2012-12-12 15:42:26 UTC Comment hidden (obsolete)
Comment 4 Fridolin Somers 2012-12-12 16:03:51 UTC
(In reply to comment #3)
> Bug 9263 - Followup - Improve speed of substitution.


Thanks.
I think also 'g' regexp option was missing in my patch.
Comment 5 Fridolin Somers 2012-12-12 16:20:56 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2012-12-12 17:24:43 UTC
Created attachment 14051 [details] [review]
Bug 9263: Trim barcodes in offline circulation

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Marcel de Rooy 2013-01-20 17:37:45 UTC
QA Comment:
Trivial patch. Did not test offline circ. But this patch is just housekeeping and trims spaces from barcode and cardnumber.
Looks good to me. Will not hurt anyone.
Passed QA
Comment 8 Jared Camins-Esakov 2013-01-23 00:12:06 UTC
This patch has been pushed to master.

Please try to remember to sign off on patches when QAing.
Comment 9 Marcel de Rooy 2013-01-23 11:50:25 UTC
(In reply to comment #8)
> This patch has been pushed to master.
> 
> Please try to remember to sign off on patches when QAing.

Hi Jared,
I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.)
Marcel
Comment 10 Marcel de Rooy 2013-01-23 11:50:25 UTC
(In reply to comment #8)
> This patch has been pushed to master.
> 
> Please try to remember to sign off on patches when QAing.

Hi Jared,
I explicitly did not add an additional signoff line because I did not test the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in such exceptional (!) cases be of use? (Also note that this is a trivial patch.)
Marcel
Comment 11 Jared Camins-Esakov 2013-01-23 13:03:36 UTC
(In reply to comment #10)
> (In reply to comment #8)
> > This patch has been pushed to master.
> > 
> > Please try to remember to sign off on patches when QAing.
> 
> Hi Jared,
> I explicitly did not add an additional signoff line because I did not test
> the offline circ as mentioned in my QA comment. Would a Passed-QA-by line in
> such exceptional (!) cases be of use? (Also note that this is a trivial
> patch.)
> Marcel

Yes, a Passed-QA-by line would be much appreciated.