Current install instructions are broken in the (1.6) step. On amd64 architectures it breaks the whole dependency tree, pulling i386 packages.
Created attachment 14015 [details] [review] Bug 9267 - Ubuntu 12.04 install docs broken Current install instructions are broken in the (1.6) step. On amd64 architectures it breaks the whole dependency tree, pulling i386 packages. This patch replaces the 'dpkg --set-selections' combo and replacess some spaces for tabs in one line. This should be cherry-picked for other releases that have 12.04 install instructions as the problem is related to multiarch. Regards To+
Created attachment 14654 [details] [review] Bug 9267 - Ubuntu 12.04 install docs broken Current install instructions are broken in the (1.6) step. On amd64 architectures it breaks the whole dependency tree, pulling i386 packages. This patch replaces the 'dpkg --set-selections' combo and replacess some spaces for tabs in one line. This should be cherry-picked for other releases that have 12.04 install instructions as the problem is related to multiarch. Regards To+ Signed-off-by: Galen Charlton <gmc@esilibrary.com>
I did a successful Git-based, dev-mode installation on a clean 12.04 VM using the instructions as modified by the patch. As a side note, it was necessary to use the squeeze-dev repository from debian.koha-community.org to get the right versions of libchi-perl and libdigest-jhash-perl for Koha 3.10.
This patch looks like it adheres to the coding standards. My only concern has been documented in splinter. I am still marking it passed QA since the change doesn't appear to have changed anything.
Comment on attachment 14654 [details] [review] Bug 9267 - Ubuntu 12.04 install docs broken Review of attachment 14654 [details] [review]: ----------------------------------------------------------------- ::: install_misc/ubuntu.12.04.packages @@ +64,4 @@ > libdatetime-perl install > libdatetime-event-ical-perl install > libdatetime-format-dateparse-perl install > +libdatetime-format-ical-perl install Why is this modified?
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11
Just curious why: git checkout -b myinstall origin was changed to: git checkout -b myinstall origin/3.10.x The latter is not "timeless" and will require continued updates. Just a thought.
(In reply to comment #8) > Just curious why: > git checkout -b myinstall origin > was changed to: > git checkout -b myinstall origin/3.10.x > The latter is not "timeless" and will require continued updates. > Just a thought. The problem is: You belive installing outside packages is only for devs [1] and thus instructions on the tarball are targeted for them and (for that reason) master is what to put there. I belive that (as with any other software package) bundled instructions are for installing the piece of software. They should be concise, and clear. I it was up to me, I'd have a different instruction files set for each Koha release. I don't put effort on maintaining that because te QA process takes so much time that this gets obsolete (this patch was targeted for the 3.10 release for instance). [1] The fact is packages is what people uses less (just quoting chris cormack on this). And instructions inside the tarball should be... for installing from that tarball. The git stuff should even be removed from there, as makes install instructions tl;dr and people willing to develop have other ways of getting the proper instructions and tutorials.