Bug 9279 - Problem with quick slip templates
Summary: Problem with quick slip templates
Status: RESOLVED DUPLICATE of bug 6261
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P1 - high major (vote)
Assignee: Vitor Fernandes
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-13 09:53 UTC by Vitor Fernandes
Modified: 2013-01-04 13:40 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9279: Problem with quick slip templates (2.19 KB, patch)
2012-12-19 17:51 UTC, Vitor Fernandes
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9279: Problem with quick slip templates (2.25 KB, patch)
2012-12-21 17:14 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Vitor Fernandes 2012-12-13 09:53:17 UTC
Yesterday I was trying the using of quick slip templates in Koha 3.8.7.
I've modified the template and then I've done one check out to one patron.
Then I tried to print the quick slip, and two thing happened:

- If I was in circulation tab of the patron, when printing the quick slip the template was used (printslip.pl was called)
- If I was in details tab of the patron, when printing the quick slip the templates wasn't used (moremember.pl was called)

Should be the template always be used besides being on circulation or details tab?
Comment 1 Vitor Fernandes 2012-12-19 17:51:59 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-12-21 16:54:09 UTC
Can't reproduce in master, versioning for 3.8
Comment 3 Vitor Fernandes 2012-12-21 17:06:11 UTC
Kyle,

I have a master clone, and the error is still there.
Code of member-toolbar.inc:

function printx_window(print_type) {
                window.open("/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %]&print=" + print_type, "printwindow");
                return false;
        }


Note that moremember.pl is always invoked.
Comment 4 Kyle M Hall 2012-12-21 17:11:41 UTC
Thanks for the info! Resetting version to master.

Kyle

(In reply to comment #3)
> Kyle,
> 
> I have a master clone, and the error is still there.
> Code of member-toolbar.inc:
> 
> function printx_window(print_type) {
>                
> window.open("/cgi-bin/koha/members/moremember.pl?borrowernumber=[%
> borrowernumber %]&print=" + print_type, "printwindow");
>                 return false;
>         }
> 
> 
> Note that moremember.pl is always invoked.
Comment 5 Kyle M Hall 2012-12-21 17:14:29 UTC
Created attachment 14252 [details] [review]
[SIGNED-OFF] Bug 9279: Problem with quick slip templates

Yesterday I was trying the using of quick slip templates in Koha 3.8.7.
I've modified the template and then I've done one check out to one patron.
Then I tried to print the quick slip, and two thing happened:

- If I was in circulation tab of the patron, when printing the quick slip the template was used (printslip.pl was called)
- If I was in details tab of the patron, when printing the quick slip the templates wasn't used (moremember.pl was called)

To test:

- change for example the quickslip template in the notices tools
- go to patrons checkout page and do a check out of one item
- try to print the quick slip in the same page, and see if the template is used
- go to the patron details tab and try to print the quick slip
- if the template is used then the bug is corrected, if not the bug still happens
- try the slip template too

Sponsored-by: KEEP SOLUTIONS
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Jonathan Druart 2013-01-04 13:40:04 UTC
The bug 6261 solves this issue.

*** This bug has been marked as a duplicate of bug 6261 ***