Created attachment 14103 [details] Export checkouts proposed revised interface The export checkouts form on the circulation page uses a YUI-generated menu button to offer export format choices. I think it would be simple to create this menu in HTML. I think it would also make the action of the form clearer.
Created attachment 14104 [details] [review] Bug 9283 - Change structure of export checkouts form This patch changes the structure of the export checkouts form so that it is a little more linear. This change moves generation of the export options from JavaScript to the markup, eliminating an instance of dependence on YUI menus. To test, enable checkout exports by specifying a value for ExportWithCsvProfile or ExportRemoveFields. Load a patron with checkouts in circulation. Try the various checkout export options. Each should function correctly.
Created attachment 14116 [details] [review] Bug 9283 - Change structure of export checkouts form This patch changes the structure of the export checkouts form so that it is a little more linear. This change moves generation of the export options from JavaScript to the markup, eliminating an instance of dependence on YUI menus. To test, enable checkout exports by specifying a value for ExportWithCsvProfile or ExportRemoveFields. Load a patron with checkouts in circulation. Try the various checkout export options. Each should function correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Thanks for this ergonomic improvement!
QA: Looking at this one..
Created attachment 15158 [details] [review] Bug 9283 - Change structure of export checkouts form This patch changes the structure of the export checkouts form so that it is a little more linear. This change moves generation of the export options from JavaScript to the markup, eliminating an instance of dependence on YUI menus. To test, enable checkout exports by specifying a value for ExportWithCsvProfile or ExportRemoveFields. Load a patron with checkouts in circulation. Try the various checkout export options. Each should function correctly. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Looks even better now. Presentation moved to template instead of javascript/yui. Works as advertised. Passed QA
This patch has been pushed to master.