In the table of checkouts on the circulation page you're not supposed to be able to check a box in both the renew and check-in column in the same row. The JavaScript which manages this works if you check the box itself, but there is also JavaScript which lets the user click anywhere in that cell to check the checkbox. If you do it this way the adjacent checkboxes are not prevented from both being checked.
Created attachment 14151 [details] [review] Bug 9289 - Adjacent checkbox behavior broken on circulation.pl This patch fixes the behavior of adjacent checkboxes in the list of checkouts on circulation.pl. Checkboxes in both the "renew" and "check in" columns should not be able to be checked at the same time. A line was commented out (by me) which was necessary to this working correctly. I'm guessing it was done in debugging and left by mistake. To test, load a patron for checkout who has items checked out. You should not be able to check boxes in both the "renew" and "check in" columns in the same row, whether you click the checkbox itself or the containing table cell.
Created attachment 14250 [details] [review] Bug 9289 - Adjacent checkbox behavior broken on circulation.pl This patch fixes the behavior of adjacent checkboxes in the list of checkouts on circulation.pl. Checkboxes in both the "renew" and "check in" columns should not be able to be checked at the same time. A line was commented out (by me) which was necessary to this working correctly. I'm guessing it was done in debugging and left by mistake. To test, load a patron for checkout who has items checked out. You should not be able to check boxes in both the "renew" and "check in" columns in the same row, whether you click the checkbox itself or the containing table cell. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA Comments: Trivial patch, works as expected. Marked as Passed QA.
Created attachment 14261 [details] [review] Bug 9289 - Adjacent checkbox behavior broken on circulation.pl This patch fixes the behavior of adjacent checkboxes in the list of checkouts on circulation.pl. Checkboxes in both the "renew" and "check in" columns should not be able to be checked at the same time. A line was commented out (by me) which was necessary to this working correctly. I'm guessing it was done in debugging and left by mistake. To test, load a patron for checkout who has items checked out. You should not be able to check boxes in both the "renew" and "check in" columns in the same row, whether you click the checkbox itself or the containing table cell. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.2