Bug 9292 - Remove dead code related to 'publictype'
Summary: Remove dead code related to 'publictype'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-14 19:43 UTC by Kyle M Hall
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9292 - Remove dead code related to 'publictype' (2.62 KB, patch)
2012-12-14 19:43 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9292 - Remove dead code related to 'publictype' (2.91 KB, patch)
2013-01-02 18:25 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9292 - Remove dead code related to 'publictype' (2.96 KB, patch)
2013-01-09 04:07 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 9292 - Remove dead code related to 'publictype' (3.01 KB, patch)
2013-01-09 15:17 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2012-12-14 19:43:18 UTC

    
Comment 1 Kyle M Hall 2012-12-14 19:43:41 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-12-27 16:32:05 UTC
This patch should have a commit message which includes a description of the problem, a description of the solution, and a test plan.
Comment 3 Kyle M Hall 2013-01-02 18:25:33 UTC Comment hidden (obsolete)
Comment 4 Galen Charlton 2013-01-09 04:07:51 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-01-09 15:16:59 UTC
QA Comment:

I did not find any occurrence of publictype. These lines are useless and can be deleted.

Marked as Passed QA.
Comment 6 Jonathan Druart 2013-01-09 15:17:15 UTC
Created attachment 14497 [details] [review]
Bug 9292 - Remove dead code related to 'publictype'

This patch removes the superflous code related to 'publictype' which
is a key set for item hashes in some perl files. This key is never
used or stored.

Test Plan:
1) Apply patch
2) Test catalogue/detail.pl, opac/opac-detail.pl and opac/opac-user.pl
3) You should not see any changes in behavior

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Jared Camins-Esakov 2013-01-13 13:38:33 UTC
This patch has been pushed to master.
Comment 8 Chris Cormack 2013-01-15 04:33:55 UTC
Pushed to 3.10.x and 3.8.x, will be in 3.10.2 and 3.8.9