Created attachment 14155 [details] [review] Bug 9295 [ENH] Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value. In OAI set mappings, the value "is equal to" is hardcoded. This enhancement changes it to a dropdown menu to choose between "is equal to" and "not equal to". To test: * define a set * define a mapping for said set with "is equal to" * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios; * change mapping to 'not equal to', save * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios;
Created attachment 14156 [details] [review] Bug 9295 [ENH] Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value. In OAI set mappings, the value "is equal to" is hardcoded. This enhancement changes it to a dropdown menu to choose between "is equal to" and "not equal to". To test: * define a set * define a mapping for said set with "is equal to" * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios; * change mapping to 'not equal to', save * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios;
Created attachment 16443 [details] [review] Bug 9295 [ENH] Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value. In OAI set mappings, the value "is equal to" is hardcoded. This enhancement changes it to a dropdown menu to choose between "is equal to" and "not equal to". To test: * define a set * define a mapping for said set with "is equal to" * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios; * change mapping to 'not equal to', save * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios;
rebased to master
Created attachment 21404 [details] [review] [SIGNED-OFF] Bug 9295 [ENH] Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value. In OAI set mappings, the value "is equal to" is hardcoded. This enhancement changes it to a dropdown menu to choose between "is equal to" and "not equal to". To test: * define a set * define a mapping for said set with "is equal to" * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios; * change mapping to 'not equal to', save * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios; Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Works fine. Nothing to say.
Works as expected, nice improvement. Marked as Passed QA.
Created attachment 21419 [details] [review] Bug 9295 [ENH] Introduce operator equal/ notequal to OAI set mapping instead of hardcoded 'equal' value. In OAI set mappings, the value "is equal to" is hardcoded. This enhancement changes it to a dropdown menu to choose between "is equal to" and "not equal to". To test: * define a set * define a mapping for said set with "is equal to" * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios; * change mapping to 'not equal to', save * run /misc/migration_tools/build_oai_sets.pl -r -v * confirm that you have correct entries in SQL: select * from oai_sets_biblios; Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Fix bug id in updatedb.pl
Pushed to master. Thanks, Mirko!