Bug 9300 - filtering export.pl by accession date does not work
Summary: filtering export.pl by accession date does not work
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jesse Weaver
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-18 17:24 UTC by SJeffery
Modified: 2014-12-07 20:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
dates in the marc aren't in the date range either (37.78 KB, image/png)
2013-05-09 15:25 UTC, Nicole C. Engard
Details
Bug 9300 - filtering export.pl by accession date does not work Small typo in query construction, fixed. To test: 1) Try filtering a MARC export using "Start date" 2) Notice the lack of filtering 3) Apply patch 4) Try export again, records are filtered by (1.16 KB, patch)
2013-06-03 19:23 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 9300 - filtering export.pl by accession date does not work (1.16 KB, patch)
2013-06-03 19:24 UTC, Jesse Weaver
Details | Diff | Splinter Review
Bug 9300 - filtering export.pl by accession date does not work (1.21 KB, patch)
2013-06-06 10:01 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 9300 - filtering export.pl by accession date does not work (1.27 KB, patch)
2013-06-07 12:13 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description SJeffery 2012-12-18 17:24:48 UTC
When using the MARC export tool at /tools/export.pl you have the option to filter the records by accession date. This feature is not currently functioning. Instead of filtering, it simply grabs all records regardless of accession date.


<oleonard>: I think I'm reproducing your bug SJeffery, given how long this export download is taking 
<oleonard>: Yup, got all records. 
<oleonard>: SJeffery: master
Comment 1 Nicole C. Engard 2013-05-09 15:25:45 UTC
Created attachment 18045 [details]
dates in the marc aren't in the date range either

This is still an issue.  I ran the export for Jan 1 2013 to today and I got results like this one:

mysql> select datecreated from biblio where biblionumber=753;

+-------------+
| datecreated |
+-------------+
| 2012-09-21  |
+-------------+

Which is obviously not right.

The MARC is attached in the image
Comment 2 Jesse Weaver 2013-06-03 19:23:14 UTC Comment hidden (obsolete)
Comment 3 Jesse Weaver 2013-06-03 19:24:17 UTC Comment hidden (obsolete)
Comment 4 Paul Poulain 2013-06-06 10:01:22 UTC
Patch tested with a sandbox, by Cedric Vita <cedric.vita@dracenie.com>
Comment 5 Paul Poulain 2013-06-06 10:01:42 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-06-07 12:13:24 UTC
Typo fix.
Marked as Passed QA.
Comment 7 Jonathan Druart 2013-06-07 12:13:39 UTC
Created attachment 18731 [details] [review]
Bug 9300 - filtering export.pl by accession date does not work

Small typo in query construction, fixed.
To test:
1) Try filtering a MARC export using "Start date"
2) Notice the lack of filtering
3) Apply patch
4) Try export again, records are filtered by dateaccessioned

Signed-off-by: Cedric Vita <cedric.vita@dracenie.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Galen Charlton 2013-06-07 15:42:44 UTC
Pushed to master.  Thanks, Jesse!
Comment 9 Tomás Cohen Arazi 2013-06-10 18:03:24 UTC
This patch has been pushed to 3.12.x, will be in 3.12.1.

Thanks Jesee!
Comment 10 Bernardo Gonzalez Kriegel 2013-06-14 20:31:53 UTC
Pushed to 3.10.x, will be in 3.10.7