On the surface, this looks like a problem from the conversion to T::T.
Created attachment 14206 [details] [review] Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u If a biblio record contained a URL, and the OPAC was using the "normal" (non-XSLT) display for records, then these links would never open a new window. With this patch, they will. Test plan: 1) have a biblio containing an 856$u link 2) set OPACurlOpenInNewWindow to "true" 3) do not use XSLT for displaying the detail pages in the OPAC 4) view the record, click the link, and note that it opens in the current window. 5) apply the patch 6) reload the detail page, click the link, and note that it opens a new window.
Note that this backports to 3.8 quite happily.
Created attachment 14207 [details] [review] Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u If a biblio record contained a URL, and the OPAC was using the "normal" (non-XSLT) display for records, then these links would never open a new window. With this patch, they will. Test plan: 1) have a biblio containing an 856$u link 2) set OPACurlOpenInNewWindow to "true" 3) do not use XSLT for displaying the detail pages in the OPAC 4) view the record, click the link, and note that it opens in the current window. 5) apply the patch 6) reload the detail page, click the link, and note that it opens a new window. Sponsored-By: National Institute of Water and Atmospheric Research
This doesn't work for me unless I replace "OPACurlOpenInNewWindow" with "OPACURLOpenInNewWindow" (matching the case of the system preference).
In that case, there'll be a multitude of bugs: $ grep OPACurlOpenInNewWindow koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | wc -l 6 Also, I just retested it, and it works for me as it's submitted here. However it does make more sense for the capitalisation to match, so I'll fix that up for this case.
Created attachment 14330 [details] [review] Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u If a biblio record contained a URL, and the OPAC was using the "normal" (non-XSLT) display for records, then these links would never open a new window. With this patch, they will. Test plan: 1) have a biblio containing an 856$u link 2) set OPACurlOpenInNewWindow to "true" 3) do not use XSLT for displaying the detail pages in the OPAC 4) view the record, click the link, and note that it opens in the current window. 5) apply the patch 6) reload the detail page, click the link, and note that it opens a new window. Sponsored-By: National Institute of Water and Atmospheric Research
Created attachment 14333 [details] [review] [SIGNED-OFF] Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u If a biblio record contained a URL, and the OPAC was using the "normal" (non-XSLT) display for records, then these links would never open a new window. With this patch, they will. Test plan: 1) have a biblio containing an 856$u link 2) set OPACurlOpenInNewWindow to "true" 3) do not use XSLT for displaying the detail pages in the OPAC 4) view the record, click the link, and note that it opens in the current window. 5) apply the patch 6) reload the detail page, click the link, and note that it opens a new window. Sponsored-By: National Institute of Water and Atmospheric Research Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA Comment: The patch fixes a variable scoping and reintroduces a broken feature. Marked as Passed QA.
Created attachment 14567 [details] [review] Bug 9309 - Make OPACurlOpenInNewWindow be respected for 856$u If a biblio record contained a URL, and the OPAC was using the "normal" (non-XSLT) display for records, then these links would never open a new window. With this patch, they will. Test plan: 1) have a biblio containing an 856$u link 2) set OPACurlOpenInNewWindow to "true" 3) do not use XSLT for displaying the detail pages in the OPAC 4) view the record, click the link, and note that it opens in the current window. 5) apply the patch 6) reload the detail page, click the link, and note that it opens a new window. Sponsored-By: National Institute of Water and Atmospheric Research Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
Pushed to 3.8.x and 3.10.x will be in 3.8.9 and 3.10.2