The patron image upload template needs a few corrections: - incorrect grid structure makes page narrower than it needs to be - information about upload results squeezed into message box illegibly - upload results should link to patron records
Created attachment 14212 [details] [review] Bug 9310 - Patron image upload template corrections This patch fixes some template structure problems and makes some improvements: - Correct grid structure so that page isn't narrower than it needs to be. - Move image upload messages out of message/error dialog and into table so that lines are distinct and legible. - Expand breadcrumbs specificity - Capitalization corrections To test: Upload patron images using both single images and zip files. Test zip file upload with a file which contains valid and invalid contents (non-existant patron numbers, invalid image files, etc). In all cases image uploads should work correctly and errors should be legibly displayed.
Created attachment 14327 [details] [review] [SIGNED-OFF] Bug 9310 - Patron image upload template corrections This patch fixes some template structure problems and makes some improvements: - Correct grid structure so that page isn't narrower than it needs to be. - Move image upload messages out of message/error dialog and into table so that lines are distinct and legible. - Expand breadcrumbs specificity - Capitalization corrections To test: Upload patron images using both single images and zip files. Test zip file upload with a file which contains valid and invalid contents (non-existant patron numbers, invalid image files, etc). In all cases image uploads should work correctly and errors should be legibly displayed. Signed-off-by: Marc Veron <veron@veron.ch> With patch, error messages are displayed in a nice table.
QA comment: This patch improves the ergonomic of the patron image upload page. Works as expected for zip and png files. Marked as Passed QA.
Created attachment 14598 [details] [review] Bug 9310 - Patron image upload template corrections This patch fixes some template structure problems and makes some improvements: - Correct grid structure so that page isn't narrower than it needs to be. - Move image upload messages out of message/error dialog and into table so that lines are distinct and legible. - Expand breadcrumbs specificity - Capitalization corrections To test: Upload patron images using both single images and zip files. Test zip file upload with a file which contains valid and invalid contents (non-existant patron numbers, invalid image files, etc). In all cases image uploads should work correctly and errors should be legibly displayed. Signed-off-by: Marc Veron <veron@veron.ch> With patch, error messages are displayed in a nice table. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Tested with zip and png files. Works great.
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x, will be in 3.10.3 and 3.8.10