One of the patches of bug 7067 introduces a new Koha perl dependency, String::Random. The patch modifies C4/Installer/PerlDependencies.pm, but the configured min_ver=1.4 is non existent. Last version of package is 0.22 (on CPAN) (http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11978&action=diff) So koha_perl_deps.pl -u will show as required an incorrect version, Installed Required Module Name Version Version ------------------------------------------------------------------------- String::Random 0.22 * 1.4
Created attachment 14253 [details] [review] Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl This patch fixes version number of String::Random as reported by koha_perl_deps.pl To test (on master) 1) run perl koha_perl_deps.pl -u, it will show as required String::Random version 1.4 2) apply the patch 3) run koha_perl_deps.pl -u, it will show (or not) as required String::Random version 0.22
Created attachment 14276 [details] [review] Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl This patch fixes version number of String::Random as reported by koha_perl_deps.pl To test (on master) 1) run perl koha_perl_deps.pl -u, it will show as required String::Random version 1.4 2) apply the patch 3) run koha_perl_deps.pl -u, it will show (or not) as required String::Random version 0.22 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patch works correctly according to the test plan.
QA Comment: The last available version on cpan for the String::Random module is 0.22 So this patch is correct. Marked as Passed QA.
Created attachment 14286 [details] [review] Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl This patch fixes version number of String::Random as reported by koha_perl_deps.pl To test (on master) 1) run perl koha_perl_deps.pl -u, it will show as required String::Random version 1.4 2) apply the patch 3) run koha_perl_deps.pl -u, it will show (or not) as required String::Random version 0.22 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Patch works correctly according to the test plan. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.