Bug 9315 - Bad version of String::Random reported by koha_perl_deps.pl
Summary: Bad version of String::Random reported by koha_perl_deps.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-21 22:14 UTC by Bernardo Gonzalez Kriegel
Modified: 2013-05-23 06:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl (1.04 KB, patch)
2012-12-21 22:26 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl (1.18 KB, patch)
2012-12-26 17:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl (1.20 KB, patch)
2012-12-27 09:38 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bernardo Gonzalez Kriegel 2012-12-21 22:14:35 UTC
One of the patches of bug 7067 introduces a new Koha perl dependency,
String::Random. The patch modifies C4/Installer/PerlDependencies.pm,
but the configured min_ver=1.4 is non existent. 
Last version of package is 0.22 (on CPAN)

(http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11978&action=diff)

So koha_perl_deps.pl -u will show as required an incorrect version,

                                              Installed         Required          Module Name                                   Version           Version            -------------------------------------------------------------------------
String::Random                                0.22 *            1.4
Comment 1 Bernardo Gonzalez Kriegel 2012-12-21 22:26:49 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2012-12-26 17:09:21 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2012-12-27 09:38:00 UTC
QA Comment:

The last available version on cpan for the String::Random module is 0.22

So this patch is correct.

Marked as Passed QA.
Comment 4 Jonathan Druart 2012-12-27 09:38:14 UTC
Created attachment 14286 [details] [review]
Bug 9315: Bad version of String::Random reported by koha_perl_deps.pl

This patch fixes version number of String::Random as reported by
koha_perl_deps.pl

To test (on master)
1) run perl koha_perl_deps.pl -u, it will show as required String::Random version 1.4
2) apply the patch
3) run koha_perl_deps.pl -u, it will show (or not) as required String::Random version 0.22

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Patch works correctly according to the test plan.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Jared Camins-Esakov 2012-12-27 15:19:36 UTC
This patch has been pushed to master.