A document with only one item that has multiple reserves is shown in circ/pendingreserves.pl even if the item is waiting for the first patron. With the patch, only items that are really available are shown.
Created attachment 14274 [details] [review] BZ 9320 : Pending reserves report (circ/pendingreserves.pl) should not show items on hold waiting to be picked up Test plan : * chose an item reserved by multiple patrons. * return the item and confirm reservation => item is waiting to be picked up * run circ/pendingreserves.pl => without patch, this item is shown in the list => with the patch, only really available items are show.
Created attachment 14278 [details] [review] BZ 9320 : Pending reserves report (circ/pendingreserves.pl) should not show items on hold waiting to be picked up Test plan : * chose an item reserved by multiple patrons. * return the item and confirm reservation => item is waiting to be picked up * run circ/pendingreserves.pl => without patch, this item is shown in the list => with the patch, only really available items are show. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 14295 [details] [review] [SIGNED-OFF] Bug 9320 Pending reserves report should not show waiting items Test plan : * chose an item reserved by multiple patrons. * return the item and confirm reservation => item is waiting to be picked up * run circ/pendingreserves.pl => without patch, this item is shown in the list => with the patch, only really available items are show. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works according to test plan. The title with one waiting item appeared in pending holds report before the patch, doesn't appear after the patch.
QA comment: Very simple patch. It fixes a specific case about holds. If a reserve is waiting, it is useless to display it in the holds to pull table. Marked as Passed QA.
Created attachment 15161 [details] [review] Bug 9320 Pending reserves report should not show waiting items Test plan : * chose an item reserved by multiple patrons. * return the item and confirm reservation => item is waiting to be picked up * run circ/pendingreserves.pl => without patch, this item is shown in the list => with the patch, only really available items are show. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Works according to test plan. The title with one waiting item appeared in pending holds report before the patch, doesn't appear after the patch. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10