Bug 9335 - Message Log Popups don't disappear?
Summary: Message Log Popups don't disappear?
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Martin Renvoize
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-31 16:30 UTC by Martin Renvoize
Modified: 2014-05-26 21:04 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Fix for bug_9335 (1.71 KB, patch)
2012-12-31 16:58 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 9335 - humanMsg popups don't dissapear in webkit browsers (1.80 KB, patch)
2013-01-04 13:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9335 - humanMsg popups don't dissapear in webkit browsers (1.87 KB, patch)
2013-01-04 14:37 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2012-12-31 16:30:38 UTC
In Google Chrome (currently running version 24.0.1312.45, but happened in many previous versions) the message popup confirming that preferences have been saved after clicking "Save all OPAC prefecernces" does not disappear.  Sometimes this popup is rather large and, along with looking bad, can actually hinder further preference changes without doing a full refresh of the page?
Comment 1 Martin Renvoize 2012-12-31 16:58:44 UTC Comment hidden (obsolete)
Comment 2 Martin Renvoize 2012-12-31 17:02:27 UTC
To test:

Head to 'Administration -> System Preferences' and edit a preference and then save it.

A grey translucent popup should appear and remain in focus until you do something (anything, i.e move the mouse). Upon your action, the box should fade out.

Test once in a webkit browser to see that the patch has fixed the issue (Chrome or Safari).

Test once in a non-webkit bowser (Firefox, IE) to test that the patch has not broken the functionality in other browsers.
Comment 3 Kyle M Hall 2013-01-04 13:27:22 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-01-04 14:36:56 UTC
QA Comment:

Patch has been created following a suggested fix from the tracker of the jQuery plugin.
It works on Debian with Google Chrome and Firefox (no regression).

Marked as Passed QA.
Comment 5 Jonathan Druart 2013-01-04 14:37:20 UTC
Created attachment 14419 [details] [review]
Bug 9335 - humanMsg popups don't dissapear in webkit browsers

The popup message that appears after saving changes to system
preferences should dissapear upon any user actions (i.e mouse
click, mouse move, typing) but this does not happen in modern
webkit based browsers since jQuery was updated.

This patch adds the suggested fix to the jQuery plugin code as
suggested on https://code.google.com/p/humanmsg/issues/detail?id=9

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Tested with Google Chrome on Windows 7

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Tested with Google Chrome 22 and Firefox on Debian
Comment 6 Jared Camins-Esakov 2013-01-08 02:16:44 UTC
This patch has been pushed to master.
Comment 7 Chris Cormack 2013-01-12 19:23:53 UTC
Pushed to 3.10.x and 3.8.x