In Google Chrome (currently running version 24.0.1312.45, but happened in many previous versions) the message popup confirming that preferences have been saved after clicking "Save all OPAC prefecernces" does not disappear. Sometimes this popup is rather large and, along with looking bad, can actually hinder further preference changes without doing a full refresh of the page?
Created attachment 14343 [details] [review] Fix for bug_9335 The popup message that appears after saving changes to system preferences should dissapear upon any user actions (i.e mouse click, mouse move, typing) but this does not happen in modern webkit based browsers since jQuery was updated. This patch adds the suggested fix to the jQuery plugin code as suggested on https://code.google.com/p/humanmsg/issues/detail?id=9 It appears that this jQuery plugin is no longer actively developed. It may be worth rethinking these warning in the future to move away from this dependency.
To test: Head to 'Administration -> System Preferences' and edit a preference and then save it. A grey translucent popup should appear and remain in focus until you do something (anything, i.e move the mouse). Upon your action, the box should fade out. Test once in a webkit browser to see that the patch has fixed the issue (Chrome or Safari). Test once in a non-webkit bowser (Firefox, IE) to test that the patch has not broken the functionality in other browsers.
Created attachment 14414 [details] [review] Bug 9335 - humanMsg popups don't dissapear in webkit browsers The popup message that appears after saving changes to system preferences should dissapear upon any user actions (i.e mouse click, mouse move, typing) but this does not happen in modern webkit based browsers since jQuery was updated. This patch adds the suggested fix to the jQuery plugin code as suggested on https://code.google.com/p/humanmsg/issues/detail?id=9 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Tested with Google Chrome on Windows 7
QA Comment: Patch has been created following a suggested fix from the tracker of the jQuery plugin. It works on Debian with Google Chrome and Firefox (no regression). Marked as Passed QA.
Created attachment 14419 [details] [review] Bug 9335 - humanMsg popups don't dissapear in webkit browsers The popup message that appears after saving changes to system preferences should dissapear upon any user actions (i.e mouse click, mouse move, typing) but this does not happen in modern webkit based browsers since jQuery was updated. This patch adds the suggested fix to the jQuery plugin code as suggested on https://code.google.com/p/humanmsg/issues/detail?id=9 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Tested with Google Chrome on Windows 7 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Tested with Google Chrome 22 and Firefox on Debian
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x