It one or more items in a multihold are not-holdable, it prevents a librarian from holding the rest of the items. It would be better to warn the librarian that some of the items won't be held instead, that way, the librarian does not need to go to the trouble of removing the non-holdable items from the multi-hold to complete the process.
Created attachment 14359 [details] [review] Bug 9336 - Don't let un-holdable records prevent holdable records from being held in Intranet for multi-holds If one or more records selected for a multi-hold have no items, the multi-holds process will prevent the librarian from completing the multi-hold. This forces the librarian to go back and remove the records with no items from the multi-hold. It would be better to warn the librarian that some of the records won't be held instead, that way, the librarian does not need to go to the trouble of removing the non-holdable records from the multi-hold to complete the process. Fixed by not disabling the submit button in the event that one of the records has no holdable items. Updated text of submit buttons.
Test plan: 1) Apply patch 2) Place a multi-hold on two records, where one has hold-able items, and the other does not have any hold-able items. 3) Instead of being unable to submit the hold request, you should now be able to.
Created attachment 14436 [details] [review] [SIGNED-OFF] Bug 9336 - Don't let un-holdable records block bulk holds If one or more records selected for a multi-hold have no items, the multi-holds process will prevent the librarian from completing the multi-hold. This forces the librarian to go back and remove the records with no items from the multi-hold. It would be better to warn the librarian that some of the records won't be held instead, that way, the librarian does not need to go to the trouble of removing the non-holdable records from the multi-hold to complete the process. Fixed by not disabling the submit button in the event that one of the records has no holdable items. Updated text of submit buttons. Test plan: 1) Apply patch for Bug 7703 2) Apply this patch 3) Place a multi-hold on two records, where one has hold-able items, and the other does not have any hold-able items. 4) Instead of being unable to submit the hold request, you should now be able to. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Copied test plan from bug report in order to fulfill commit message requirements.
This patch depends on 7703 that is failed QA right now.