Bug 9349 - Saved reports: sort broken on creation date
Summary: Saved reports: sort broken on creation date
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Adrien SAURAT
QA Contact:
URL:
Keywords:
Depends on: 9108 9182
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-04 16:25 UTC by Adrien SAURAT
Modified: 2014-12-07 20:02 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (1.01 KB, patch)
2013-01-04 16:35 UTC, Adrien SAURAT
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9349: fix on date sort in Saved Reports (1.22 KB, patch)
2013-01-04 16:56 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien SAURAT 2013-01-04 16:25:38 UTC
The sort on creation date does not work with non-US dates.
Comment 1 Adrien SAURAT 2013-01-04 16:35:23 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-01-04 16:56:29 UTC
Created attachment 14426 [details] [review]
[SIGNED-OFF] Bug 9349: fix on date sort in Saved Reports

Allows the dd/mm/yyyy format to be correctly sorted
in the Saved Reports table.

TEST PLAN :
Try with different date formats (system preference "dateformat")
Before patch, the "dd/mm/yyyy" is not well sorted.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2013-01-15 11:35:21 UTC
Hi Adrien,

I link this bug with 9108.
Have a look to it and see the new way to check the dateformat pref.
This new way will become a new best practice.

So your patch will be:
+    [% IF ( dateformat == "metric" ) %]dateFormat: 'uk',[% END %]

Marked as Failed QA
Comment 4 Jonathan Druart 2013-05-28 15:37:04 UTC
Bug 9466 introduces Datatable on this page. This patch becomes useless.