MARC fields 029, 863, 864 and 865 don't have corresponding subfields on default and example MARC21 frameworks
Created attachment 14440 [details] [review] Bug 9353 - Missing subfields on MARC21 frameworks This patch adds missing subfields on MARC fields 029abct (http://www.oclc.org/bibformats/en/0xx/029.shtm) 863abcdefghijklmnopqstvwxz68 (same for 864/5) (http://www.loc.gov/marc/holdings/hd863865.html) To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply the patch 7) Replace old frameworks, easiest by command line: mysql -uuser -ppass kohadb -e 'delete from biblio_framework; delete from marc_tag_structure; delete from marc_subfield_structure' mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql 8) Repeat steps 2-4 9) Click 'Subfields', now they are.
Note that this only seems to apply for new installs - I don't see updatedatabase.pl file in the patch. Is that right? Nicole
(In reply to comment #2) > Note that this only seems to apply for new installs - I don't see > updatedatabase.pl file in the patch. Is that right? Yes, you are right. I'll look how to do that. Bernardo
Created attachment 14532 [details] [review] Followup Bug 9353: Missing subfields on MARC21 frameworks This followup changes updatedatabase.pl. Only touch frameworks that have the missing subfields. If both patches are applied, the test plan changes. To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply both patches 7) run 'perl installer/data/mysql/updatedatabase.pl' 8) Repeat steps 2-4 9) Click 'Subfields', now they are.
Created attachment 14699 [details] [review] Bug 9353 - Missing subfields on MARC21 frameworks This patch adds missing subfields on MARC fields 029abct (http://www.oclc.org/bibformats/en/0xx/029.shtm) 863abcdefghijklmnopqstvwxz68 (same for 864/5) (http://www.loc.gov/marc/holdings/hd863865.html) To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply the patch 7) Replace old frameworks, easiest by command line: mysql -uuser -ppass kohadb -e 'delete from biblio_framework; delete from marc_tag_structure; delete from marc_subfield_structure' mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql 8) Repeat steps 2-4 9) Click 'Subfields', now they are. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 14700 [details] [review] Followup Bug 9353: Missing subfields on MARC21 frameworks This followup changes updatedatabase.pl. Only touch frameworks that have the missing subfields. If both patches are applied, the test plan changes. To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply both patches 7) run 'perl installer/data/mysql/updatedatabase.pl' 8) Repeat steps 2-4 9) Click 'Subfields', now they are. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Hi Bernardo, could you provide a follow-up (maybe on a separate bug) for the fast add framework?
Created attachment 16466 [details] [review] [PASSED QA] Bug 9353 - Missing subfields on MARC21 frameworks This patch adds missing subfields on MARC fields 029abct (http://www.oclc.org/bibformats/en/0xx/029.shtm) 863abcdefghijklmnopqstvwxz68 (same for 864/5) (http://www.loc.gov/marc/holdings/hd863865.html) To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply the patch 7) Replace old frameworks, easiest by command line: mysql -uuser -ppass kohadb -e 'delete from biblio_framework; delete from marc_tag_structure; delete from marc_subfield_structure' mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql mysql -uuser -ppass kohadb < installer/data/mysql/en/marcflavour/marc21/optional/marc21_simple_bib_frameworks.sql 8) Repeat steps 2-4 9) Click 'Subfields', now they are. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Updated frameworks are ok. Note: Only en frameworks are updated, so if other languages need those fields too, we need some followups. Also Fast Add framework is missing.
Created attachment 16467 [details] [review] [PASSED QA] Followup Bug 9353: Missing subfields on MARC21 frameworks This followup changes updatedatabase.pl. Only touch frameworks that have the missing subfields. If both patches are applied, the test plan changes. To test: 1) dev master system with default and example MARC21 frameworks 2) Go to Home > Administration > MARC frameworks 3) Click on 'MARC structure' of any framework 4) Search for tag 029 (or 863/4/5) 5) Click 'Subfields', there are none. 6) Apply both patches 7) run 'perl installer/data/mysql/updatedatabase.pl' 8) Repeat steps 2-4 9) Click 'Subfields', now they are. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Update works nicely. Checked various frameworks and results were ok. Also new fields are hidden.
This patch has been pushed to master.
Needed for Bug 5858 Pushed to 3.10.x, will be in 3.10.10
Pushed to 3.8.x, will be in 3.8.18