Bug 9360 - Clean borrowers tool wording and layout problematic
Summary: Clean borrowers tool wording and layout problematic
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-08 03:04 UTC by Jared Camins-Esakov
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
bug 9360 - Clean borrowers tool wording and layout problematic (6.68 KB, patch)
2013-01-08 03:54 UTC, Liz Rea
Details | Diff | Splinter Review
bug 9360 - Clean borrowers tool wording and layout problematic (6.62 KB, patch)
2013-01-08 19:48 UTC, Liz Rea
Details | Diff | Splinter Review
bug 9360 - Clean borrowers tool wording and layout problematic (6.63 KB, patch)
2013-01-08 21:48 UTC, Liz Rea
Details | Diff | Splinter Review
bug 9360 - Clean borrowers tool wording and layout problematic (7.48 KB, patch)
2013-01-09 19:42 UTC, Liz Rea
Details | Diff | Splinter Review
bug 9360 - Clean borrowers tool wording and layout problematic (6.62 KB, patch)
2013-01-10 22:53 UTC, Galen Charlton
Details | Diff | Splinter Review
bug 9360 - Clean borrowers tool wording and layout problematic (7.77 KB, patch)
2013-01-10 22:54 UTC, Galen Charlton
Details | Diff | Splinter Review
bug 9360 - Clean borrowers tool wording and layout problematic (9.98 KB, patch)
2013-01-13 19:55 UTC, Liz Rea
Details | Diff | Splinter Review
[SIGNED-OFF] bug 9360 - Clean borrowers tool wording and layout problematic (10.09 KB, patch)
2013-01-14 07:06 UTC, Marc Véron
Details | Diff | Splinter Review
bug 9360 - Clean borrowers tool wording and layout problematic (11.99 KB, patch)
2013-01-14 09:04 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2013-01-08 03:04:54 UTC
The wording in the clean borrowers tool is not idiomatic, and the layout with the three options under "Delete borrowers" is confusing.
Comment 1 Liz Rea 2013-01-08 03:54:50 UTC Comment hidden (obsolete)
Comment 2 Liz Rea 2013-01-08 03:56:08 UTC
Suppose I should note that this work is based on bug 9076, which was just pushed today.
Comment 3 Owen Leonard 2013-01-08 14:10:31 UTC
This has a few minor errors which prevent it from validating as well-formed XHTML:

- A missing quotation mark on line 68: id=borrower_dateexpiry"
- Two instances of "<br>" which should be "<br />"
Comment 4 Liz Rea 2013-01-08 19:37:19 UTC
righto - will fix those (though the 2nd one is not my doing :))
Comment 5 Liz Rea 2013-01-08 19:41:08 UTC
The first, I mean. Gah.
Comment 6 Liz Rea 2013-01-08 19:48:46 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2013-01-08 20:14:56 UTC
Now we've got "<br \>" instead of "<br />"
Comment 8 Liz Rea 2013-01-08 21:48:44 UTC Comment hidden (obsolete)
Comment 9 Galen Charlton 2013-01-09 04:40:34 UTC
Another nit: "checkout" occurs far more frequently than "check-out" in existing templates.  "check-out", which this patch uses throughout, is currently used only in the following two templates:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt
koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/patron-attr-types.tt

I don't much care which form is used, but we should be consistent.
Comment 10 Liz Rea 2013-01-09 19:42:53 UTC Comment hidden (obsolete)
Comment 11 Galen Charlton 2013-01-10 22:53:47 UTC Comment hidden (obsolete)
Comment 12 Galen Charlton 2013-01-10 22:54:06 UTC Comment hidden (obsolete)
Comment 13 Jonathan Druart 2013-01-11 14:28:51 UTC
This patch introduces many tabulation characters.
Please resubmit it replacing tab with 4 spaces.

Marked as Failed QA.
Comment 14 Liz Rea 2013-01-13 19:55:37 UTC Comment hidden (obsolete)
Comment 15 Liz Rea 2013-01-13 19:57:03 UTC
last patch fixes all instances of tab characters, and incorporates Galen's change.
Comment 16 Marc Véron 2013-01-14 07:06:13 UTC Comment hidden (obsolete)
Comment 17 Jonathan Druart 2013-01-14 09:04:22 UTC
QA Comments:

No regression found.
This patch works as expected, the title is changed on each page.
It adds bullet points on the Batch patron deletion/anonymization page.
Other changes are indentation.

Marked as Passed QA.
Comment 18 Jonathan Druart 2013-01-14 09:04:53 UTC
Created attachment 14558 [details] [review]
bug 9360 - Clean borrowers tool wording and layout problematic

To test:

Verify that the text has been changed to "Batch patron deletion/anonymization in the following places:

* tools-home
* the page title
* the heading on cleanborrowers
* the menu on cleanborrowers

Verify that the tool still works as intended.

This (finally) fixes the things Owen pointed out.
changes check-out to checkout per Galen.

Signed-off-by: Marc Veron <veron@veron.ch>
Behaves as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Fix indentation and tabulations characters
Comment 19 Jared Camins-Esakov 2013-01-15 03:52:50 UTC
This patch has been pushed to master.