The wording in the clean borrowers tool is not idiomatic, and the layout with the three options under "Delete borrowers" is confusing.
Created attachment 14456 [details] [review] bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. Other ergonomic change suggestions welcomed.
Suppose I should note that this work is based on bug 9076, which was just pushed today.
This has a few minor errors which prevent it from validating as well-formed XHTML: - A missing quotation mark on line 68: id=borrower_dateexpiry" - Two instances of "<br>" which should be "<br />"
righto - will fix those (though the 2nd one is not my doing :))
The first, I mean. Gah.
Created attachment 14473 [details] [review] bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. Other ergonomic change suggestions welcomed.
Now we've got "<br \>" instead of "<br />"
Created attachment 14476 [details] [review] bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out.
Another nit: "checkout" occurs far more frequently than "check-out" in existing templates. "check-out", which this patch uses throughout, is currently used only in the following two templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/patron-attr-types.tt I don't much care which form is used, but we should be consistent.
Created attachment 14507 [details] [review] bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. changes check-out to checkout per Galen.
Created attachment 14533 [details] [review] bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out.
Created attachment 14534 [details] [review] bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. changes check-out to checkout per Galen. [Patch also amended by Galen Charlton to update the description on the tools page to use the word "patrons".] Signed-off-by: Galen Charlton <gmc@esilibrary.com>
This patch introduces many tabulation characters. Please resubmit it replacing tab with 4 spaces. Marked as Failed QA.
Created attachment 14551 [details] [review] bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. changes check-out to checkout per Galen.
last patch fixes all instances of tab characters, and incorporates Galen's change.
Created attachment 14554 [details] [review] [SIGNED-OFF] bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. changes check-out to checkout per Galen. Signed-off-by: Marc Veron <veron@veron.ch> Behaves as expected.
QA Comments: No regression found. This patch works as expected, the title is changed on each page. It adds bullet points on the Batch patron deletion/anonymization page. Other changes are indentation. Marked as Passed QA.
Created attachment 14558 [details] [review] bug 9360 - Clean borrowers tool wording and layout problematic To test: Verify that the text has been changed to "Batch patron deletion/anonymization in the following places: * tools-home * the page title * the heading on cleanborrowers * the menu on cleanborrowers Verify that the tool still works as intended. This (finally) fixes the things Owen pointed out. changes check-out to checkout per Galen. Signed-off-by: Marc Veron <veron@veron.ch> Behaves as expected. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Fix indentation and tabulations characters
This patch has been pushed to master.