There is a problem that brokens the interface of moremmeber when displaying the date expiry caused by this line: <strong class="reregistryinfo">[% dateexpiry %]</span> It should be: <span class="reregitryinfo">[% dateexpiry %]</span> It happens in version 3.8. In version 3.10, I don't know if the problem happens.
Created attachment 14529 [details] [review] Bug 9376: Problem with dateexpiry display in moremember.tt There is a problem that brokens the interface of moremmeber when displaying the date expiry when renewing a patron. In the first comment I said that the line that causes the error should be: <span class="reregitryinfo">[% dateexpiry %]</span> but the correct way should be: <strong class="reregitryinfo">[% dateexpiry %]</strong> This way the date expiry after renew a patron appears in bold. Test plan: - after apply the patch try to renew a patron and check that almost everything went bold - apply the patch - renew a patron and only the date expiry is bolder. Sponsored-by: KEEP SOLUTIONS
Confirmed that this affect 3.10.x. It doesn't affect master, but only because of how the patch for bug 6261 reworks the member toolbar to use member/setstatus.pl rather than members/moremember.pl to renew the patron.
Created attachment 14628 [details] [review] Bug 9376: Problem with dateexpiry display in moremember.tt There is a problem that brokens the interface of moremmeber when displaying the date expiry when renewing a patron. In the first comment I said that the line that causes the error should be: <span class="reregitryinfo">[% dateexpiry %]</span> but the correct way should be: <strong class="reregitryinfo">[% dateexpiry %]</strong> This way the date expiry after renew a patron appears in bold. Test plan: - before applying the patch try to renew a patron and check that almost everything went bold - apply the patch - renew a patron and only the expiration date is bolder. - Note that the bug doesn't manifest in master because the patch for bug 6261 causes the invalid HTML to never be reached; it *does* affect 3.10.x and earlier. Sponsored-by: KEEP SOLUTIONS Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 14629 [details] [review] Bug 9376: extend HTML fix to moremember-brief.tt Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Note that I added a follow-up patch along with my signoff.
QA comment: The patch fixes a malformed strong tag. Marked as Passed QA.
Created attachment 14662 [details] [review] Bug 9376: Problem with dateexpiry display in moremember.tt There is a problem that brokens the interface of moremmeber when displaying the date expiry when renewing a patron. In the first comment I said that the line that causes the error should be: <span class="reregitryinfo">[% dateexpiry %]</span> but the correct way should be: <strong class="reregitryinfo">[% dateexpiry %]</strong> This way the date expiry after renew a patron appears in bold. Test plan: - before applying the patch try to renew a patron and check that almost everything went bold - apply the patch - renew a patron and only the expiration date is bolder. - Note that the bug doesn't manifest in master because the patch for bug 6261 causes the invalid HTML to never be reached; it *does* affect 3.10.x and earlier. Sponsored-by: KEEP SOLUTIONS Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 14663 [details] [review] Bug 9376: extend HTML fix to moremember-brief.tt Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10