This happens in 3.8.5 and maybe later versions as well. Do this on your DB: select distinct branch from statistics where type='writeoff'; There is only ever 1 branch in there. Even if you have 2,5,40 branches doing writeoffs all writeoffs get the same branch - it's not the first alphabetical either, I'm not sure where it's coming from and haven't had time to test much more thoroughly. I did however test on 4 library systems running 3.8.5 and got the same results on all - one branch only recorded when writing off. Nicole
Created attachment 14666 [details] [review] Bug 9380 - branch not recording right on writeoff Test Plan: 1) Write off fines as various branches 2) Observe the stats lines include the wrong branchcode 3) Apply patch 4) Repeate step 1 5) Observe the stats lines include the correct branchcode
Created attachment 14820 [details] [review] [SIGNED-OFF] Bug 9380 - branch not recording right on writeoff Test Plan: 1) Write off fines as various branches 2) Observe the stats lines include the wrong branchcode 3) Apply patch 4) Repeate step 1 5) Observe the stats lines include the correct branchcode Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Also tested by changing branch and writing off again - all tests pass.
Created attachment 14901 [details] [review] [SIGNED-OFF] Bug 9380 - branch not recording right on writeoff Test Plan: 1) Write off fines as various branches 2) Observe the stats lines include the wrong branchcode 3) Apply patch 4) Repeate step 1 5) Observe the stats lines include the correct branchcode Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Also tested by changing branch and writing off again - all tests pass. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 15185 [details] [review] [SIGNED-OFF] Bug 9380 - branch not recording right on writeoff Test Plan: 1) Write off fines as various branches 2) Observe the stats lines include the wrong branchcode 3) Apply patch 4) Repeate step 1 5) Observe the stats lines include the correct branchcode Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Also tested by changing branch and writing off again - all tests pass. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked individual and complete write off for different branches. Write offs were always recorded correctly for the logged in branch. All tests and QA script pas.
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.3, does not apply to 3.8.x please resubmit for 3.8.x if needed