In master because of the new feature to allow patrons to register for a card via the opac when you have OPACPatronDetails set to 'don't allow' it still shows a from for the patron details, but you can't edit the form. It would be better if this showed as a text display like it used to so that it's not confusing to patrons (even with the note about seeing the librarian). Nicole
The code for the old form was never removed so it should be trivial to enable Koha to pick which one to show based on whether or not OPAC registration is enabled.
Created attachment 14596 [details] [review] Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows Because of the new feature to allow patrons to register for a card via the opac when you have OPACPatronDetails set to 'don't allow' it still shows a from for the patron details, but you can't edit the form. It would be better if this showed as a text display like it used to so that it's not confusing to patrons ( even with the note about seeing the librarian ).
Created attachment 14597 [details] [review] Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows Because of the new feature to allow patrons to register for a card via the opac when you have OPACPatronDetails set to 'don't allow' it still shows a from for the patron details, but you can't edit the form. It would be better if this showed as a text display like it used to so that it's not confusing to patrons ( even with the note about seeing the librarian ). Test Plan: 1) Apply patch 2) Log into OPAC 3) Set OPACPatronDetails to "Allow" 4) Refresh the page and click "my personal details" 5) Verify you get the editable form ( opac-memberentry.pl ) 6) Set OPACPatronDetails to "Don't allow" 7) Refresh the page and click "my personal details" again 8) Verify you get the non-editable non-form details page ( opac-userupdate.pl )
Created attachment 14966 [details] [review] Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows Because of the new feature to allow patrons to register for a card via the opac when you have OPACPatronDetails set to 'don't allow' it still shows a from for the patron details, but you can't edit the form. It would be better if this showed as a text display like it used to so that it's not confusing to patrons ( even with the note about seeing the librarian ). Test Plan: 1) Apply patch 2) Log into OPAC 3) Set OPACPatronDetails to "Allow" 4) Refresh the page and click "my personal details" 5) Verify you get the editable form ( opac-memberentry.pl ) 6) Set OPACPatronDetails to "Don't allow" 7) Refresh the page and click "my personal details" again 8) Verify you get the non-editable non-form details page ( opac-userupdate.pl ) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Passes tests, works as advertised
QA comment: Works as expected, simple patch. Marked as Passed QA.
Created attachment 14971 [details] [review] Bug 9384 - With OPACPatronDetails set to 'don't allow' a form shows Because of the new feature to allow patrons to register for a card via the opac when you have OPACPatronDetails set to 'don't allow' it still shows a from for the patron details, but you can't edit the form. It would be better if this showed as a text display like it used to so that it's not confusing to patrons ( even with the note about seeing the librarian ). Test Plan: 1) Apply patch 2) Log into OPAC 3) Set OPACPatronDetails to "Allow" 4) Refresh the page and click "my personal details" 5) Verify you get the editable form ( opac-memberentry.pl ) 6) Set OPACPatronDetails to "Don't allow" 7) Refresh the page and click "my personal details" again 8) Verify you get the non-editable non-form details page ( opac-userupdate.pl ) Signed-off-by: Liz Rea <liz@catalyst.net.nz> Passes tests, works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch works as far as it goes, but it does not add any check to opac-memberentry.pl to redirect the user if they end up on that page with OPACPatronDetails set to "Don't allow," and it really needs to before I push it.
(In reply to comment #7) > This patch works as far as it goes, but it does not add any check to > opac-memberentry.pl to redirect the user if they end up on that page with > OPACPatronDetails set to "Don't allow," and it really needs to before I push > it. So I think the followup will delete some tests in the opac-memberentry.tt template ([% IF OPACPatronDetails %]).
Is this bug still valid?
As far as I can tell this is no longer valid.