When you reach the maximum number of times a book can be renewed in regards to the settings of circulation settings the alert box is difficult to read when using screen reader software and also difficult to navigate to as it is in plain text and in a list which is also reasonably far down the html page in most cases.
Created attachment 14575 [details] [review] Added header tags to error message to make it more accessible
Created attachment 14582 [details] [review] Bug 9389 added header tags to error message to test: -search for a patron -issue a book that cannot be renewed (dependant on circulation rules) -error should show with error message "No more renewals possible," but be wrapped in a <h5> Signed-off-by: Liz Rea <liz@catalyst.net.nz>
This change doesn't really make sense. In the template we have a lot of possible errors. Here are a few: [% IF ( DEBARRED ) %] <li>Patron is restricted</li> [% END %] [% IF ( NO_MORE_RENEWALS ) %] <h5><li>No more renewals possible</li></h5> [% END %] [%IF ( AGE_RESTRICTION ) %] <li>Age restriction [% AGE_RESTRICTION %].</li> [% END %] [% IF ( EXPIRED ) %] <li>Patron's card is expired</li> [% END %] 1. <h5> inside an <li> is not valid XHTML. 2. It doesn't make sense to wrap only one of many possible error messages in <h5> It would make more sense, I think, to add a heading to the message box itself: <div id="circ_impossible" class="dialog alert"> <!-- RESULT OF ISSUING REQUEST --> <h5>Could not complete checkout</h5> ...and have the list of messages below. Would this fulfill the same requirements?
Created attachment 14608 [details] [review] Moved header tags to improve patch I've made the changes suggested by Owen - moved header tags to cover full range of options. (This also obsoletes my patch on Bug 9390 which is very similar)