Bug 9389 - Accessibility - "no more renewals" alert box difficult to access for screen-reader users
Summary: Accessibility - "no more renewals" alert box difficult to access for screen-...
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Bart Jorgensen
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-15 00:53 UTC by Bart Jorgensen
Modified: 2014-12-07 20:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Added header tags to error message to make it more accessible (1.05 KB, patch)
2013-01-15 01:06 UTC, Bart Jorgensen
Details | Diff | Splinter Review
Bug 9389 added header tags to error message to test: (1.16 KB, patch)
2013-01-15 03:13 UTC, Liz Rea
Details | Diff | Splinter Review
Moved header tags to improve patch (1.50 KB, patch)
2013-01-15 21:37 UTC, Bart Jorgensen
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Bart Jorgensen 2013-01-15 00:53:13 UTC
When you reach the maximum number of times a book can be renewed in regards to the settings of circulation settings the alert box is difficult to read when using screen reader software and also difficult to navigate to as it is in plain text and in a list which is also reasonably far down the html page in most cases.
Comment 1 Bart Jorgensen 2013-01-15 01:06:37 UTC Comment hidden (obsolete)
Comment 2 Liz Rea 2013-01-15 03:13:01 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2013-01-15 13:45:12 UTC
This change doesn't really make sense. In the template we have a lot of possible errors. Here are a few:

        [% IF ( DEBARRED ) %]
            <li>Patron is restricted</li>
        [% END %]

        [% IF ( NO_MORE_RENEWALS ) %]
            <h5><li>No more renewals possible</li></h5>
        [% END %]

        [%IF ( AGE_RESTRICTION ) %]
            <li>Age restriction [% AGE_RESTRICTION %].</li>
        [% END %]

        [% IF ( EXPIRED ) %]
            <li>Patron's card is expired</li>
        [% END %]

1. <h5> inside an <li> is not valid XHTML.
2. It doesn't make sense to wrap only one of many possible 
   error messages in <h5>

It would make more sense, I think, to add a heading to the message box itself:

<div id="circ_impossible" class="dialog alert">
<!-- RESULT OF ISSUING REQUEST -->
<h5>Could not complete checkout</h5>

...and have the list of messages below. Would this fulfill the same requirements?
Comment 4 Bart Jorgensen 2013-01-15 21:37:57 UTC
Created attachment 14608 [details] [review]
Moved header tags to improve patch

I've made the changes suggested by Owen - moved header tags to cover full range of options. 

(This also obsoletes my patch on Bug 9390 which is very similar)