the options under the search box on most pages (eg: on the mainpage: checkout, check in, search patrons... etc.) are not classed as buttons which means screen readers read them separately to the search box and it isn't clear that they are related, or that changing the options effects the box. In addition to this on some pages there are identically named links that are very difficult to distinguish between when only using a screen reader.
Created attachment 14613 [details] [review] Added div roles to search box options to increase accessibility
Created attachment 14616 [details] [review] {PATCH PASSED // MORE WORKED NEEDED?} -- Added div roles to search box options to increase accessibility The patch will need to be worked on. Read Testing Procedure within the Description of Patch.
(In reply to comment #2) > The patch will need to be worked on. What does this mean? Do you have any references citing the utility of the changes made? I don't see any outward effects on the interface from a sighted person's point of view, so I'm fine with the change if it is a practical improvement. A more complex solution might be to upgrade jQuery to 1.9, which adds ARIA support to widgets like Tabs.
I'm marking this "failed QA" because it's not clear whether this patch is really ready for signoff ("The patch will need to be worked on"). I would like to understand better why the changes are being made.
Still valid?